-
Notifications
You must be signed in to change notification settings - Fork 84
Update to .NET 8 #1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Update to .NET 8 #1283
Conversation
andrew-welker
commented
Jul 7, 2025
- fix: update package references and clean up unused imports
- fix: update target frameworks and package references; change culture to InvariantCulture
- feat: implement WebSocket classes and update culture settings; bump PepperDashCore version
- fix: update target framework to net8 and bump PepperDashCore version to 2.0.0-alpha-462
- wip: address performance issues in plugin loading and versioning
- feat: enhance plugin dependency management in PluginLoader
- fix: update condition for CPZ copy target and remove obsolete workflows
- fix: adjust installation steps for prerequisites based on environment detection
- wip: package updates
- docs: add XML comments
- chore: fix issues related to remving crestron usings
- docs: update XML docs
- feat: modify plugin loading process
- chore: move all files to file-scoped namespace
- feat: remove context file for storing values
- feat: modify factory loading
- chore: update local build version
…to InvariantCulture
…epperDashCore version
…to 2.0.0-alpha-462 BREAKING CHANGE: Target Framework is now .NET 8:
Updating IDeviceFactory to resolve [FEATURE]-Refactor Plugin loading mechanism #1065. This change should be backwards-compatible with existing plugins that use the EssentialsPluginDeviceFactory<T> class, as the interfaces are implemented by the various base classes. In addition, the correct assembly name is now printed when a type is loaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
The PR upgrades the codebase to .NET 8, converts all namespaces to C# file-scoped syntax, and enhances plugin loading with .NET 8 compatibility checks.
- Update project to target .NET 8 and bump package references
- Convert all
namespace { }blocks to file-scopednamespace X; - Revamp
PluginLoaderto perform assembly compatibility analysis and track incompatible plugins
Reviewed Changes
Copilot reviewed 300 out of 573 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| *.csproj | Changed <TargetFramework> to net8 and updated package refs |
All .cs files |
Converted block namespaces to file-scoped namespace X; |
| PluginLoader.cs | Rewrote plugin loading logic, added .NET 8 compatibility checks, revamped collections initialization |
Comments suppressed due to low confidence (5)
src/PepperDash.Essentials.Core/PepperDash.Essentials.Core.csproj:6
- The TargetFramework identifier should follow the format 'netX.Y' (e.g., 'net8.0') rather than 'net8'.
<TargetFramework>net8</TargetFramework>
src/PepperDash.Essentials.Core/Plugins/PluginLoader.cs:105
- Square-bracket collection expressions initialize arrays, not List. Use 'new List()' to instantiate the list.
LoadedAssemblies = [];
src/PepperDash.Essentials.Core/Plugins/PluginLoader.cs:106
- Square-bracket collection expressions initialize arrays, not List. Use 'new List()' to instantiate the list.
LoadedPluginFolderAssemblies = [];
src/PepperDash.Essentials.Core/Plugins/PluginLoader.cs:107
- Square-bracket collection expressions initialize arrays, not List. Use 'new List()' to instantiate the list.
EssentialsPluginAssemblies = [];
src/PepperDash.Essentials.Core/Plugins/PluginLoader.cs:108
- Square-bracket collection expressions initialize arrays, not List. Use 'new List()' to instantiate the list.
IncompatiblePlugins = [];
Co-authored-by: Copilot <[email protected]>