Skip to content

Allow custom functionality on the TedImagePickerActivity by opening some classes and functions #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arqlz wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow custom functionality on the TedImagePickerActivity by opening some classes and functions #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef64ead
Update TedImagePickerActivity.kt
arqlz Nov 27, 2021
e1b06ae
Update TedRxImagePicker.kt
arqlz Nov 27, 2021
4b110b2
Update TedImagePickerBaseBuilder.kt
arqlz Nov 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tedimagepicker/src/main/java/gun0912/tedimagepicker/TedImagePickerActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import java.util.concurrent.TimeUnit
import kotlin.collections.ArrayList


internal class TedImagePickerActivity : AppCompatActivity() {
open class TedImagePickerActivity : AppCompatActivity() {

private lateinit var binding: ActivityTedImagePickerBinding
private val albumAdapter by lazy { AlbumAdapter(builder) }
Expand Down Expand Up @@ -268,7 +268,7 @@ internal class TedImagePickerActivity : AppCompatActivity() {
}

@SuppressLint("CheckResult")
private fun onCameraTileClick() {
open fun onCameraTileClick() {
val (cameraIntent, uri) = MediaUtil.getMediaIntentUri(
this@TedImagePickerActivity,
builder.mediaType,
Expand Down
6 changes: 5 additions & 1 deletion tedimagepicker/src/main/java/gun0912/tedimagepicker/builder/TedImagePickerBaseBuilder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,12 @@ open class TedImagePickerBaseBuilder<out B : TedImagePickerBaseBuilder<B>>(
.setPermissions(Manifest.permission.READ_EXTERNAL_STORAGE)
.request()

private open fun getIntent(context: Context): Intent {
// allow to use a custom activity intent
return TedImagePickerActivity.getIntent(context, this)
}
private fun startActivity(context: Context) {
TedImagePickerActivity.getIntent(context, this)
getIntent(context, this)
.run {
TedRxOnActivityResult.with(context).startActivityForResult(this)
}.run {
Expand Down
2 changes: 1 addition & 1 deletion tedimagepicker/src/main/java/gun0912/tedimagepicker/builder/TedRxImagePicker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class TedRxImagePicker {
}

@SuppressLint("ParcelCreator")
class Builder(private val contextWeakReference: WeakReference<Context>) :
open class Builder(private val contextWeakReference: WeakReference<Context>) :
TedImagePickerBaseBuilder<Builder>() {

fun start(): Single<Uri> =
Expand Down