Skip to content

Reduce changes to session history entry #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Reduce changes to session history entry #230

wants to merge 1 commit into from

Conversation

PaperStrike
Copy link
Owner

@PaperStrike PaperStrike commented Nov 2, 2021 •
edited
Loading

Motivation and Context

  • Ignore session history entries that are not pushed / replaced by Pjax.
  • Change window scroll restoration mode only when needed.
  • Use the scrollRestoration option when leaving, not entering a page.

How Has This Been Tested?

Unfortunately, there isn't a test plan for src/index.ts, yet.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor (no bug fix and new feature but improvements)

Checklist:

  • My change requires new tests.
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@PaperStrike
Reduce changes to session history entry
e959437 
* Ignore session history entries that are not pushed by Pjax.
* Change window scroll restoration mode only when needed.
* Use the `scrollRestoration` option when leaving, not entering a page.
@PaperStrike PaperStrike added enhancement New feature or request minor Pull requests that require a minor version update labels Nov 2, 2021
@PaperStrike PaperStrike marked this pull request as draft November 2, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request minor Pull requests that require a minor version update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PaperStrike