feature(api): Remove BossBarViewer#1370
Open
TurboJax wants to merge 18 commits into
Open
Conversation
Member
|
The existing methods need deprecation in 4.x. |
Author
|
I don't think I can do that on this pr, so I'll make a second one in to add the deprecation warnings. I'll link it here when it's been made. |
Author
|
Just made a pr that deprecates functions on the main/4 branch |
This still isn't perfect, but we shouldn't break the contract and return `null` when we parse any other primitive string as a text component.
Strokkur424
suggested changes
May 28, 2026
…into turbo/no_bbv
Co-authored-by: Strokkur24 <strokkur.24@gmail.com>
Author
|
Awesome, thanks for the reviews! Sorry that I missed that merge conflict, I'll double check the implementations again to make sure I didn't miss anything else. About #1376, I'll rebase that soon. |
Author
|
Hey thinking about making the BossBar#viewers and Audience#activeBossBars functions return |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply removes the BossBarViewer class and moves its one function over to the Audience class. All references to BossBarViewer have been made compatible with the Audience class.
Original Issue: #1349