feat(text-logger-slf4j): add structured log context injector hook#1366
Open
jpenilla wants to merge 3 commits into
Open
feat(text-logger-slf4j): add structured log context injector hook#1366jpenilla wants to merge 3 commits into
jpenilla wants to merge 3 commits into
Conversation
- add internal ComponentLogContextInjector and ComponentLogRecord types for forwarding raw component log metadata - extend ComponentLoggerProvider.LoggerHelper with backward-compatible delegating(..., injector) overload - wire Handler.LoggerHelperImpl to construct WrappingComponentLoggerImpl with optional injector - wrap all enabled log paths in WrappingComponentLoggerImpl with injector scope begin/close, swallowing injector errors and preserving existing output behavior - add tests for raw record capture, throwable forwarding, scope close lifecycle, and injector failure tolerance This will allow for Endermux to forward rich log messages over the socket.
Member
|
How worried are we about the unconditional extra allocations from capturing new |
- inline context scope management in WrappingComponentLoggerImpl - replace withContext(..., Runnable) lambdas with explicit beginContext + try/finally closeContext - preserve injector error-swallowing behavior and existing logging semantics - remove now-unused withContext helper method
Member
Author
|
I think it's a valid concern, I've inlined the scope management. |
Member
Author
|
I was able to get Endermux working with this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow for Endermux to forward rich log messages over the socket.