Remove duplicated reloads while calling addRecipe()

[Ph0sphorW]

I forgot to create a new branch first sry

While trying to add a recipe through this method, the server will resent the ClientboundUpdateRecipesPacket twice.

I found this when I was testing my custom recipe loading plugin. When I tried to reload all the custom recipes (had 150 of them...) my client had no response for a half a minute. After checking client logs I found that my client reloaded the recipe book for 600 times.

The full calling chain before:

CraftServer.addRecipe(...)
  → toAdd.addToRecipeManager()
    → RecipeManager.addRecipe(...)
      → finalizeRecipeLoading()
        → PlayerList.reloadResources()
          → reloadRecipes()          // 1
  → if (true || resendRecipes)
      → reloadRecipes()              // 2

We'd see that the playerList.reloadRecipes() ran twice in total, and remove the second reloadRecipes() didn't affect the reloading at all.
So here's the fixed logic (after):

CraftServer.addRecipe(...)
  → toAdd.addToRecipeManager()
    → RecipeManager.addRecipe(...)
      → finalizeRecipeLoading()
        → PlayerList.reloadResources()
          → reloadRecipes()          // 1

I didn't remove the 2nd param for backward compatibility issues.
Sorry for my poor English expression🙏🏻

[Doc94]

Hi, Thanks for the PR, yeah looks like the logic its called twice.. this also happen with the removeRecipe, if you can remove that reload too i feel this PR its ok.

maybe deprecate that methods because are always reloaded internally...

[masmc05]

Since this was with a TODO, maybe it would make sense to make it false && and update the command to say that it's already resent?

[Doc94]

i dont see a reason for keep this in code when NMS already make the reload maybe mention here in the addToRecipeMananger with a comment about how that call a reloadResources -> reloadRecipes

[Ph0sphorW]

For sure add a comment would be better. My bad
I've added them in new commit

If there's any issue you may change it directly cuz I may not reply timely thx

[Doc94]

This comments can be removed (the Paper end too and maybe inline the return with the remove)

[Ph0sphorW]

Got that. Removed in latest commit

[Doc94]

Can be good deprecate the methods where the bool is passed because its totally ignored.

[JustAHuman-xD]

this is actually covered in my pre-existing recipe PR here: #13945

[JustAHuman-xD]

this is actually covered in my pre-existing recipe PR here: #13945

Which I see now I need to update with paper's update to the new mc version