Conversation
roccodev
force-pushed
the
fix/track-events
branch
from
September 19, 2026 21:22
f023609 to
6cfb070
Compare
roccodev
marked this pull request as ready for review
September 19, 2026 21:22
Author
|
Ohh I just saw #12320, it didn't come up in searches, apologies. |
github-project-automation
Bot
moved this from Awaiting review
to Closed
in Paper PR Queue
roccodev
added a commit
to ProjectKig/KigPaper-NG
that referenced
this pull request
Sep 20, 2026
Port of PaperMC#14282, fix for PaperMC#14280 as a feature patch cause this was hell to rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14280
Apparently it was also the case that when
PlayerTrackEntityEventis cancelled, the entity still actually gets tracked, it's really just the spawn packet and the initial entity data/movement/etc. that's sent with it that would get cancelled. This would for example mean that when cancelling the event, plugins like ViaVersion would get confused because they'd receive packets for an entity that's not tracked.It's worth noting that this breaks plugins that would e.g. cancel the event and then later spawn the entity themselves with packets, it would previously work because the entity was still tracked under the hood, they will now need to call
hidePlayerandshowPlayer, or re-track the entity internally. I doubt that such a setup would have been supported anyway.