Open
Conversation
|
Thanks for your contribution! |
Collaborator
|
为什么提到release/2.9版本? |
Author
release/2.7~release/2.9版本和当前最新的版本不是一个实现逻辑,辛苦您对比看下 |
Collaborator
@XiaoDongGuoGuo 您好!感谢贡献PR,您的修改原因和代码已经收到,但我们还需要进行批量测试以验证正确性和兼容性,预计国庆前后给出回复。 另外,您的代码风格未通过,建议使用pre-commit工具进行修复,假设本地的git remote设置中,upstream是指官方仓库,origin是指自己的fork,那么在本地开发分支上执行: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed bug for issues #16008