Add language support check for PP-OCRv5 model in PaddleOCR#15428
Open
thejjw wants to merge 1 commit intoPaddlePaddle:mainfrom
Open
Add language support check for PP-OCRv5 model in PaddleOCR#15428thejjw wants to merge 1 commit intoPaddlePaddle:mainfrom
thejjw wants to merge 1 commit intoPaddlePaddle:mainfrom
Conversation
|
Thanks for your contribution! |
Contributor
Author
|
commit fa621ef integrated yesterday includes similar code to my pr that checks the languages and effectively resolves the issue, albeit without giving proper credit one might say. i don't know why my pr is left without reaction but i guess you can close the issue. thanks. |
Collaborator
|
Thank you for taking the time to help fix the issue. In fact, we need to change the default model here from mobile to server and add relevant monitoring. Therefore, your PR has not been merged. We really appreciate your initiative in addressing this problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a check for language support in the PP-OCRv5 model
context: #15373
The language check for v5 is based on the readme documentation that says "🌐 Single-model support for five text types - eamlessly process Simplified Chinese, Traditional Chinese, Simplified Chinese Pinyin, English and Japanse within a single model."