feat: add 2 weight functions in multi-label#2952
Open
thsno02 wants to merge 5 commits intoPaddlePaddle:developfrom
Open
feat: add 2 weight functions in multi-label#2952thsno02 wants to merge 5 commits intoPaddlePaddle:developfrom
thsno02 wants to merge 5 commits intoPaddlePaddle:developfrom
Conversation
|
Thanks for your contribution! |
cuicheng01
reviewed
Oct 30, 2023
|
|
||
|
|
||
| def ratio2weight(targets, ratio): | ||
| def ratio2weight_1(targets, ratio): |
Collaborator
There was a problem hiding this comment.
这里的1、2、3是官方repo的命名方式吗?
Contributor
Author
There was a problem hiding this comment.
https://github.com/valencebond/Rethinking_of_PAR/blob/master/tools/function.py 官方 repo 只有一个,命名中无后缀。1、2、3 是按论文给的顺序给出来的。
Collaborator
There was a problem hiding this comment.
建议这里只定义一个函数ratio2weight,里边增加参数mode,mode可以是1,2,3,在注释中说明下区别
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
根据 #2951 新增两个 ratio2weight 函数。代码里延续论文中的命名,所以原
ratios2weight改为ratios2weight_1。Type 3 示例:
Type 2/1 示例:
但是 https://github.com/PaddlePaddle/PaddleClas/blob/release/2.5/ppcls/loss/dmlloss.py 中 import 了
ratio2weight这个函数,目前的解决方案是在 dmlloss 中开启 weight_type 和 weight_alpha 这两个参数,与 multilabelloss 中保持一致,然后计算对应的 loss。