Implement Trips feature (behind feature flag)#1912
Implement Trips feature (behind feature flag)#1912Copilot wants to merge 8 commits intodevelopmentfrom
Conversation
…display, and search filtering Co-authored-by: andrew-bierman <94939237+andrew-bierman@users.noreply.github.com>
|
It looks like your comment got cut off — could you share what you'd like me to look at or change? Happy to address any feedback! |
|
It looks like your comment may have been submitted without any text. Could you share what you'd like me to look at or change? |
|
@coderabbitai Please review this PR for code quality, best practices, and potential issues. |
|
✅ Actions performedFull review triggered. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds local search/filtering to TripListScreen, shows formatted trip date ranges in TripCard, tightens upcoming-trip date parsing with parseLocalDate, re-exports trips hooks/types, updates a modal translation key to Changes
Sequence DiagramsequenceDiagram
participant User
participant TripListScreen
participant useMemo
participant FlatList
participant TripCard
User->>TripListScreen: type in search bar (onChangeText)
TripListScreen->>TripListScreen: set searchValue
TripListScreen->>useMemo: compute filteredTrips(trips, searchValue)
useMemo-->>TripListScreen: return filteredTrips
TripListScreen->>FlatList: update data = filteredTrips
FlatList->>TripCard: render trip item
TripCard->>TripCard: formatLocalDate(startDate / endDate)
TripCard-->>User: display trip with formatted dates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
apps/expo/features/trips/components/TripCard.tsx (1)
12-16: Consider locale-aware date formatting for better UX.The current implementation extracts the raw
YYYY-MM-DDdate portion, which works but may not be ideal for all users. Consider usingtoLocaleDateString()for locale-aware formatting:♻️ Optional: Locale-aware date formatting
function formatTripDate(dateString?: string): string { if (!dateString) return '—'; - const datePart = dateString.split('T')[0]; - return datePart ?? '—'; + try { + return new Date(dateString).toLocaleDateString(); + } catch { + return '—'; + } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/expo/features/trips/components/TripCard.tsx` around lines 12 - 16, The current formatTripDate function returns the raw YYYY-MM-DD chunk; update it to parse the input into a Date and use Date.prototype.toLocaleDateString (optionally with a locale or Intl.DateTimeFormat options) to produce a locale-aware string, ensure you handle undefined/invalid inputs by returning '—', and guard against timezone/parsing issues (e.g., use new Date(dateString) and check isNaN(date.getTime()) before calling toLocaleDateString) so formatTripDate always returns a safe, localized string.apps/expo/features/trips/screens/TripListScreen.tsx (1)
53-66: Empty state may confuse users when search yields no results.The
ListEmptyComponentalways shows "No trips yet" with a create button, but this same message appears when a search returns no matches. Consider differentiating between "no trips exist" vs "no search results":♻️ Suggested differentiation for empty states
const renderEmptyState = () => { + // Differentiate between no trips and no search results + if (searchValue.trim() && trips.length > 0) { + return ( + <View className="flex-1 items-center justify-center p-8"> + <Text className="text-muted-foreground">{t('trips.noSearchResults')}</Text> + </View> + ); + } return ( <View className="flex-1 items-center justify-center p-8"> <View className="mb-4 rounded-full bg-muted p-4">This requires adding a
trips.noSearchResultstranslation key.Also applies to: 91-91, 98-98
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/expo/features/trips/screens/TripListScreen.tsx` around lines 53 - 66, The empty-state UI in renderEmptyState (used as ListEmptyComponent) always shows the "no trips yet" message and create button, which is misleading when a search yields zero matches; update renderEmptyState to accept a parameter or read the current search/filter state (e.g., a prop or local state like searchQuery) and conditionally render two variants: one for "no trips exist" using t('trips.noTripsYet') and create button that calls handleCreateTrip, and another for "no search results" that shows t('trips.noSearchResults') without suggesting creation; add the new translation key trips.noSearchResults and ensure the component locations referenced in the diff use the updated renderEmptyState signature or conditional logic.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apps/expo/features/trips/components/TripCard.tsx`:
- Around line 12-16: The current formatTripDate function returns the raw
YYYY-MM-DD chunk; update it to parse the input into a Date and use
Date.prototype.toLocaleDateString (optionally with a locale or
Intl.DateTimeFormat options) to produce a locale-aware string, ensure you handle
undefined/invalid inputs by returning '—', and guard against timezone/parsing
issues (e.g., use new Date(dateString) and check isNaN(date.getTime()) before
calling toLocaleDateString) so formatTripDate always returns a safe, localized
string.
In `@apps/expo/features/trips/screens/TripListScreen.tsx`:
- Around line 53-66: The empty-state UI in renderEmptyState (used as
ListEmptyComponent) always shows the "no trips yet" message and create button,
which is misleading when a search yields zero matches; update renderEmptyState
to accept a parameter or read the current search/filter state (e.g., a prop or
local state like searchQuery) and conditionally render two variants: one for "no
trips exist" using t('trips.noTripsYet') and create button that calls
handleCreateTrip, and another for "no search results" that shows
t('trips.noSearchResults') without suggesting creation; add the new translation
key trips.noSearchResults and ensure the component locations referenced in the
diff use the updated renderEmptyState signature or conditional logic.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6dbab0a4-5422-4a3d-955f-237824e48805
📒 Files selected for processing (4)
apps/expo/app/(app)/_layout.tsxapps/expo/features/trips/components/TripCard.tsxapps/expo/features/trips/index.tsapps/expo/features/trips/screens/TripListScreen.tsx
|
@copilot CodeRabbit has provided review feedback on this PR. Please address the comments and suggestions. Once you've made the necessary changes, I'll ask CodeRabbit to re-review. |
…ated empty states Co-authored-by: andrew-bierman <94939237+andrew-bierman@users.noreply.github.com>
Addressed both CodeRabbit suggestions in commit
|
|
@copilot CodeRabbit has reviewed this PR and provided feedback. Please address the review comments and push updates. Once you've made the changes, the monitor will ask CodeRabbit to re-review. |
|
@coderabbitai Copilot has pushed updates. Please re-review. |
|
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/expo/features/trips/components/UpcomingTripsTile.tsx`:
- Around line 22-27: The upcoming-trips predicate currently excludes trips whose
parsed startDate equals today because parseLocalDate(t.startDate) yields local
midnight and the code checks parsed > new Date(); update the filter used in
trips.filter so that it includes same-day trips by comparing only the date
portion (e.g. compare parsed >= startOfToday or compare parsed.toDateString()
=== today.toDateString()) instead of strict > new Date(); adjust the predicate
around parseLocalDate(t.startDate) and the condition that returns parsed != null
&& ... so trips starting today are counted as upcoming.
In `@apps/expo/features/trips/screens/TripListScreen.tsx`:
- Around line 31-40: filteredTrips currently trims searchValue only for the
empty check but uses the untrimmed value for matching, causing queries with
leading/trailing spaces to miss matches; inside the useMemo for filteredTrips
(the hook using searchValue and trips) compute a trimmed query first (e.g.,
const query = searchValue.trim()), use that for the empty check and for building
the lowercase matcher (e.g., const lower = query.toLowerCase()), then run the
existing trips.filter logic against lower so matches ignore surrounding
whitespace; keep the dependency array as [trips, searchValue].
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d2256609-88b0-4283-b19f-918a9d4004e5
📒 Files selected for processing (9)
apps/expo/app/(app)/_layout.tsxapps/expo/features/trips/components/TripCard.tsxapps/expo/features/trips/components/UpcomingTripsTile.tsxapps/expo/features/trips/index.tsapps/expo/features/trips/screens/TripListScreen.tsxapps/expo/features/trips/types.tsapps/expo/lib/i18n/locales/en.jsonapps/expo/lib/i18n/types.tsapps/expo/lib/utils/dateUtils.ts
|
👋 @copilot |
|
@coderabbitai Copilot has pushed updates. Please re-review. |
|
✅ Actions performedReview triggered.
|
|
👋 @copilot |
- TripCard: Handle optional startDate/endDate with proper null checks, only show arrow separator when both dates exist - UpcomingTripsTile: Compare against start-of-today instead of current time so same-day trips are included in upcoming filter - TripListScreen: Trim search query before lowercasing to avoid missed matches from trailing whitespace
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
formatTripDateto usetoLocaleDateString()with invalid-date guard (TripCard.tsx)trips.noSearchResultstranslation key (en.json)YYYY-MM-DDstrings as local dates inTripCard.tsxandUpcomingTripsTile.tsx?? ''for optionaldescription/location.namebefore.includes()(TripListScreen.tsx)parseLocalDate: reject dates that normalize (e.g.2024-02-31→ March) by comparing constructed date fields back to original year/month/day (dateUtils.ts)Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Summary by CodeRabbit
New Features
Bug Fixes