Implement half-width katakana support #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
reviewed
Aug 16, 2025
| hira.push(hira_char); | ||
| previous_kana = Some(hira_char); | ||
| } else if is_char_halfwidth_katakana(input_char) { | ||
| let result = HALFWIDTH_KATAKANA_TO_HIRAGANA_NODE_TREE.get(&chars[index..]); |
Owner
There was a problem hiding this comment.
I'd prefer a pos variable that gets incremented instead of the previous_read_forward_count.
Contributor
Author
|
@PSeitz Can you take a look again on this, so that I can finish this 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19
(recreation of #20 due to accidental repo cleanup)
utils/halfwidth_katakana_to_hiragana...._to_hiraganautil can be leveraged into_hiragana's character loops so the input is not enumerated multiple times.to_katakanaandto_romaji, the util is invoked only when input contains half-width kana,to_haflwidth_katakanaor new option is NOT added, since I don't need such.