Duplicate records by ravishanigarapu · Pull Request #83 · PSMRI/ECD-API

ravishanigarapu · 2025-05-26T11:41:01Z

📋 Description

JIRA ID:

Please provide a summary of the change and the motivation behind it. Include relevant context and details.

✅ Type of Change

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

Summary by CodeRabbit

Bug Fixes
- Improved handling of call closure for introductory calls, especially when language preferences are involved, ensuring accurate call status and allocation updates.
- Prevented duplicate saving of outbound call records during allocation, enhancing system efficiency and reliability.

coderabbitai · 2025-05-26T11:41:07Z

Walkthrough

The changes update call status and allocation logic in CallClosureImpl.java, particularly for "introductory" calls and language mapping scenarios. In CallAllocationImpl.java, redundant database save operations are removed to prevent double-saving of outbound call lists. No method signatures are altered.

Changes

File(s)	Change Summary
src/main/java/com/iemr/ecd/service/associate/CallClosureImpl.java	Modified call closure logic: updated handling for "introductory" calls, language mapping, and allocation status.
src/main/java/com/iemr/ecd/service/call_conf_allocation/CallAllocationImpl.java	Removed redundant `saveAll` calls to prevent duplicate outbound call list persistence.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CallClosureImpl
    participant OutboundCallsRepo

    User->>CallClosureImpl: closeCall(request)
    alt Call type is "introductory" and disconnected with preferred language
        CallClosureImpl->>CallClosureImpl: Set status to "OPEN"
        Note right of CallClosureImpl: Allocation status update is disabled
    else Call is answered
        CallClosureImpl->>CallClosureImpl: Set status to "COMPLETED"
    end
    alt Language not mapped and call type is "introductory"
        CallClosureImpl->>CallClosureImpl: Reset allocated user ID, set status "OPEN", reset attempt number
        CallClosureImpl->>CallClosureImpl: Set allocation status to "UNALLOCATED"
    end
    CallClosureImpl->>OutboundCallsRepo: Persist changes (if needed)

Possibly related PRs

AMM-1204 #57: Updates to CallClosureImpl.java related to call status and date handling logic.
ECD Reports and highrisk #50: Changes to repository method signatures and outbound call management, overlapping with call handling logic.
AMM-1450 |Records still visible in MO worklist after unallocating all records #71: Adds new query methods and refactors call allocation logic, closely related to call status and allocation changes.

Poem

A hop, a skip, through code we go,
Tweaking calls so logic flows.
No double saves—just single hops,
And language checks for intro stops.
With status set and bugs now closed,
This rabbit’s proud—improvements posed!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 05e8236 and 1807daa.

📒 Files selected for processing (2)

src/main/java/com/iemr/ecd/service/associate/CallClosureImpl.java (2 hunks)
src/main/java/com/iemr/ecd/service/call_conf_allocation/CallAllocationImpl.java (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Analyze (java)

🔇 Additional comments (2)

src/main/java/com/iemr/ecd/service/call_conf_allocation/CallAllocationImpl.java (1)

100-197: Verify the save operation placement in allocateMotherRecordsAssociates method

The method has two distinct branches based on whether preferredLanguage is provided:

When preferredLanguage is not null (lines 125-151): Fetches existing outbound calls and saves them after updating

When preferredLanguage is null (lines 152-191): Creates new outbound calls and saves them

Both save operations appear necessary for their respective branches. The AI summary mentions removing redundant saves, but both saves handle different data sets.

Likely an incorrect or invalid review comment.

src/main/java/com/iemr/ecd/service/associate/CallClosureImpl.java (1)

205-212: Good implementation of language-based reallocation logic

The logic correctly handles the scenario where an agent doesn't have the beneficiary's preferred language mapped. For introductory calls, it properly:

Clears the allocated user

Sets status to OPEN

Resets attempt counter

Marks as unallocated for reassignment

This ensures calls can be reallocated to language-compatible agents.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2025-05-26T11:41:37Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ravishanigarapu added 2 commits May 26, 2025 16:41

If call disconnected call status open

8941559

Duplicate save issue

1807daa

helenKaryamsetty approved these changes May 26, 2025

View reviewed changes

helenKaryamsetty merged commit 045255a into PSMRI:develop May 26, 2025
7 checks passed

This was referenced May 26, 2025

Callallocation count mismatch #84

Merged

Call status open if language not mapped #85

Merged

Allocation status changed #86

Merged

Is furthercallrequired fix #92

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Duplicate records#83

Duplicate records#83
helenKaryamsetty merged 2 commits intoPSMRI:developfrom
ravishanigarapu:develop

ravishanigarapu commented May 26, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 26, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

sonarqubecloud Bot commented May 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ravishanigarapu commented May 26, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📋 Description

✅ Type of Change

ℹ️ Additional Information

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

sonarqubecloud Bot commented May 26, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ravishanigarapu commented May 26, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)