Conversation
📝 WalkthroughWalkthroughThe kibana service definition in the docker-compose.yml file has been commented out, disabling its deployment while preserving the configuration as a reference. All other services and infrastructure definitions remain unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
amrit-local-setup/docker-compose.yml (1)
9-9:⚠️ Potential issue | 🟠 MajorHardcoded plaintext credentials in a committed file.
MYSQL_ROOT_PASSWORD,MONGO_INITDB_ROOT_PASSWORD, andELASTIC_PASSWORDare all stored in plaintext. Even for a local-setup compose file, committing static passwords creates a risk surface (credential reuse, accidental promotion to non-local environments).Consider replacing them with environment variable references backed by a
.envfile (git-ignored):🔒 Proposed fix: use a `.env` file for secrets
.env(add to.gitignore):MYSQL_ROOT_PASSWORD=1234 MONGO_ROOT_PASSWORD=1234 ELASTIC_PASSWORD=piramalES- MYSQL_ROOT_PASSWORD: 1234 + MYSQL_ROOT_PASSWORD: ${MYSQL_ROOT_PASSWORD}- MONGO_INITDB_ROOT_PASSWORD: 1234 + MONGO_INITDB_ROOT_PASSWORD: ${MONGO_ROOT_PASSWORD}- - ELASTIC_PASSWORD=piramalES + - ELASTIC_PASSWORD=${ELASTIC_PASSWORD}Also applies to: 36-36, 57-57
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@amrit-local-setup/docker-compose.yml` at line 9, The docker-compose.yml currently contains hardcoded credentials (MYSQL_ROOT_PASSWORD, MONGO_INITDB_ROOT_PASSWORD, ELASTIC_PASSWORD); update docker-compose.yml to reference environment variables (e.g. ${MYSQL_ROOT_PASSWORD}, ${MONGO_INITDB_ROOT_PASSWORD}, ${ELASTIC_PASSWORD}) instead of literal values, add a .env file (git-ignored) containing those secrets for local use (e.g. MYSQL_ROOT_PASSWORD=..., MONGO_INITDB_ROOT_PASSWORD=..., ELASTIC_PASSWORD=...) and add .env to .gitignore so credentials are not committed; ensure any other occurrences (mentioned lines around the file) are similarly switched to the env variable references and remove the plaintext values from the repository.
🧹 Nitpick comments (1)
amrit-local-setup/docker-compose.yml (1)
79-99: Add a tracking comment so "temporary" doesn't become permanent.The PR description and commit message both say this is temporary, but there is no in-file reminder or linked ticket pointing back to when/why to re-enable Kibana.
📝 Suggested tracking comment
- # kibana: + # TODO: Re-enable kibana when observability dashboards are needed again. + # Ref: <JIRA-ticket-or-GitHub-issue-link> + # kibana:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@amrit-local-setup/docker-compose.yml` around lines 79 - 99, Add a short tracking comment above the commented-out kibana service block (the kibana: commented section) that marks this as temporary, references a ticket/issue ID or PR number, the author and date, and an intended revisit timeframe or condition for re-enabling (e.g., "re-enable when XYZ ticket resolved" or date). Place it immediately above the kibana: commented block so future readers see why it’s disabled and how/when to restore it.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@amrit-local-setup/docker-compose.yml`:
- Line 9: The docker-compose.yml currently contains hardcoded credentials
(MYSQL_ROOT_PASSWORD, MONGO_INITDB_ROOT_PASSWORD, ELASTIC_PASSWORD); update
docker-compose.yml to reference environment variables (e.g.
${MYSQL_ROOT_PASSWORD}, ${MONGO_INITDB_ROOT_PASSWORD}, ${ELASTIC_PASSWORD})
instead of literal values, add a .env file (git-ignored) containing those
secrets for local use (e.g. MYSQL_ROOT_PASSWORD=...,
MONGO_INITDB_ROOT_PASSWORD=..., ELASTIC_PASSWORD=...) and add .env to .gitignore
so credentials are not committed; ensure any other occurrences (mentioned lines
around the file) are similarly switched to the env variable references and
remove the plaintext values from the repository.
---
Nitpick comments:
In `@amrit-local-setup/docker-compose.yml`:
- Around line 79-99: Add a short tracking comment above the commented-out kibana
service block (the kibana: commented section) that marks this as temporary,
references a ticket/issue ID or PR number, the author and date, and an intended
revisit timeframe or condition for re-enabling (e.g., "re-enable when XYZ ticket
resolved" or date). Place it immediately above the kibana: commented block so
future readers see why it’s disabled and how/when to restore it.
1 participant
📋 Description
JIRA ID:
N/A
✅ Type of Change
Summary by CodeRabbit
Release Notes