Add JIT heap free spaces checks to EE JIT #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSI-Rockin
requested changes
Mar 15, 2020
| //Need to check we have space on the heap before running any recompiled code | ||
| //Resetting the heap during recompilation wipes out the prologue/epilogue! | ||
| //Checks for maximum 5mb block size of space before continuing | ||
| if (!jit_heap.has_free_space(1024 * 1024 * 5)) |
Owner
There was a problem hiding this comment.
I do not think this is the best place to make the JIT space check, especially considering how expensive the check is. We already have a flush_jit_cache variable that gets checked when EmotionEngine::run_jit is called.
Since only recompilation can decrease free space, a better course of action would be to do the space check inside the JIT's recompile_block method. When the check fails, we can set the flush_jit_cache variable in EmotionEngine, which will not only prevent the prologue/epilogue blocks from being trashed but also provide a speed boost compared to the current method in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.