Skip to content

🐛 feat(containers) enforce CGNS name validation across tree insertion#313

Open
casenave wants to merge 4 commits intomainfrom
fix/issue-312
Open

🐛 feat(containers) enforce CGNS name validation across tree insertion#313
casenave wants to merge 4 commits intomainfrom
fix/issue-312

Conversation

@casenave
Copy link
Member

@casenave casenave commented Feb 22, 2026

Checklist

  • Typing enforced
  • Documentation updated
  • Changelog updated
  • Tests and Example updates
  • Coverage should be 100%

🔗 Related issues (optional)

Closes #312

@casenave casenave requested a review from a team as a code owner February 22, 2026 13:03
@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@casenave
Copy link
Member Author

Thanks a lot @daviddanan for trying the lib and proposing an issue :)
Do you think that the curreent PR solves your issue ?

@casenave
Copy link
Member Author

casenave commented Feb 22, 2026

Adding the check to the Muscat CGNSBridge as well, see this MR.

@daviddanan
Copy link

daviddanan commented Feb 22, 2026

Thanks a lot @daviddanan for trying the lib and proposing an issue :) Do you think that the curreent PR solves your issue ?

You are welcome! I am still investigating to isolate some unexpected behaviour, expect other issues soon.
Yes, such error handling seems fine, thanks. It is clear enough to fix the issue on the user end.

edit: in fact, 32 characters is ok for CGNS so shorter or equal to 32 is acceptable.

@casenave
Copy link
Member Author

edit: in fact, 32 characters is ok for CGNS so shorter or equal to 32 is acceptable.

Updated for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding scalar whose name lenght greater than 32 causes error,

3 participants