Fix Bug in HaarWaveletTransform3D, Added correct output packing with k=8 #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final einops.rearrange in HaarWaveletTransform3D.forward incorrectly used k=c, which is only true when C==8. Even though it seems like it works I am guessing because we have just specified incorrect k, so it compensates the rest with c. The first dimension of the stacked outputs is 8*(B*C), so the proper factorization is (b k c) with k=8.