Skip to content

Conversation

@oleibman
Copy link
Collaborator

@oleibman oleibman commented Dec 4, 2025

Add property to right-align numeric fields.

Make most private properties/methods protected.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Add property to right-align numeric fields.

Make most private properties/methods protected.
oleibman added a commit to oleibman/phpspreadsheet-smart-cache that referenced this pull request Dec 4, 2025
We don't need to report microseconds - seconds is sufficient.

Right-align numbers when that feature is available in PhpSpreadsheet [TextGrid](PHPOffice/PhpSpreadsheet#4735).
@oleibman oleibman enabled auto-merge December 5, 2025 02:57
@oleibman oleibman added this pull request to the merge queue Dec 5, 2025
Merged via the queue into PHPOffice:master with commit 954fb87 Dec 5, 2025
14 checks passed
@oleibman oleibman deleted the gridright branch December 5, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant