Skip to content

Conversation

adars47
Copy link

@adars47 adars47 commented Jul 31, 2020

Microsoft authenticator needs that extra parameter to get the app name correct.

Microsoft authenticator needs that extra parameter to get the app name correct.
@MarkMaldaba
Copy link

Not sure why you are calling urlencode() inside urlencode(). That will result in double-escaping!

Also, for the record, this doesn't only affect Microsoft Authenticator - other apps are also affected (e.g. FreeOTP).

Note that PR #76 contains an alternative solution to the same problem, though it also suffers from the double-escaping issue.

@MarkMaldaba MarkMaldaba mentioned this pull request Mar 12, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants