Reports/*blame: properly escape file name - #1473
Merged
Merged
Conversation
This is a security fix for CVE-2026-67434 / [GHSA-hmqg-cxww-wqhq](GHSA-hmqg-cxww-wqhq). Properly escape file names before calling the `* blame` command to prevent maliciously crafted file names from potentially running system commands. Includes tests covering the fix for the `Gitblame` report. Notes: * While the issue could not be reproduced on Windows with the current proof of concept, the tests should still _run_ on Windows to safeguard that the issue continues to not exist for Windows. * Similar test(s) should be added for the `Hgblame` and `Svnblame` reports, but that will require installing those version management systems in a GitHub Actions environment and possibly initializing a system directory for Mercurial/Svn to be able to recognize the file for use with the `blame` command. This needs further investigation, which is outside the scope of the security fix. Co-authored-by: Volker Dusch <247397+edorian@users.noreply.github.com> Co-authored-by: Dan Wallis <dan@wallis.nz> Co-authored-by: Rodrigo Primo <rodrigosprimo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a security fix for CVE-2026-67434 / GHSA-hmqg-cxww-wqhq.
Properly escape file names before calling the
* blamecommand to prevent maliciously crafted file names from potentially running system commands.Includes tests covering the fix for the
Gitblamereport.Notes:
HgblameandSvnblamereports, but that will require installing those version management systems in a GitHub Actions environment and possibly initializing a system directory for Mercurial/Svn to be able to recognize the file for use with theblamecommand. This needs further investigation, which is outside the scope of the security fix.Suggested changelog entry
Gitblame,HgblameorSvnblamereport(s) would process a file whose name contains shell metacharacters. [Reports/*blame: properly escape file name #1473]Fullreport, or any of the other non-*blame reports, are not affected.Types of changes