FSUI: Load all language fonts at all times #13589

TellowKrinkle · 2025-11-23T07:31:27Z

Description of Changes

Allow use of system fonts
Load all language fonts instead of just the one supported by the current locale
mmap fonts instead of copying them into memory
Enable non-English game titles in FSUI
Allow slightly wider title strings on horizontal FSUI buttons
Center icons in their buttons on the FSUI nav bar

Fixes #12804

Rationale behind Changes

No more prompts to download fonts when using non-latin languages unless your system is missing that font
Don't need to ship 25MB Noto Color Emoji on Windows (still needed on macOS and Linux)
Can use non-English game titles in FSUI
Non-English characters in paths render properly in FSUI
Save ~75MB of ram when using the 25MB Noto Color Emoji font

Suggested Testing Steps

Delete any downloaded fonts from your PCSX2 directory
Make sure you don't get prompted to download any fonts (unless on Linux and don't have Noto fonts)
Make sure non-English game titles render properly in FSUI
Make sure fonts look nice in your language in FSUI (Arabic is still broken, sorry)
Make sure line height looks reasonable everywhere in FSUI (lines shouldn't look like they're squished against each other)

Notes

Font sizes have changed for non-latin fonts. Translators will need to re-check FSUI to make sure their translations still fit.
Linux packagers should add Noto Sans {CJK, Arabic, Hebrew, Devanagari} to the recommended dependencies of their packages.

Did you use AI to help find, test, or implement this issue or feature?

No

pcsx2/ImGui/ImGuiManager.cpp

TheLastRar

translation.cpp needs to be formatted, any sections where you disagree with clang-format probably should have // clang-format off/on comments added.

I've not reviewed the added freetype code or the patches to imgui.

common/FileSystem.cpp

TheLastRar · 2025-11-26T12:36:45Z

pcsx2-qt/Translations.cpp

-	{"ko-KR", "NotoSansKR-Regular.ttf"},
-	{"zh-CN", "NotoSansSC-Regular.ttf"},
-	{"zh-TW", "NotoSansTC-Regular.ttf"},
+static constexpr const struct { const char* name; FontScript script; } s_language_scripts[] = {


I didn't know you could do this

pcsx2/ImGui/ImGuiFullscreen.cpp

TheLastRar · 2025-11-26T15:33:40Z

pcsx2/ImGui/ImGuiFullscreen.cpp

 	static InputLayout s_gamepad_layout = InputLayout::Unknown;
 } // namespace ImGuiFullscreen

+static float GetLineHeight(std::pair<ImFont*, float> font)


I'm assuming this function should be used anywhere where font.second is used outside of the ImGui calc and draw text functions?

In that case, it is needed in various locations in Achievements.cpp, FullscreenUI.cpp and ImGuiOverlays.cpp
Additionally, extra consideration needs to be taken for any code that calls ImGuiManager::Get*Font() and ImGuiManager::GetFontSize*(), as they would need to reassemble the std::pair to get the LineHeight

Things sometimes look fine if you don't include the line height, especially when e.g. adding underlines under text like in the section headers, where including the line height looks worse IMO.

I don't have an RA account so I just blindly applied it to a bunch of stuff in Achievements.cpp, someone should actually look at those interfaces and see if things look ok.

Might want to document exactly when GetLineHeight should or shouldn't be used

There isn't an exact place it should be used. GetLineHeight produces a number similar to what the font size was before fixing imgui, which was a pretty arbitrary number before. For new code, the way to use it is "Look at rendered UI. Does it look nice? If so, great. If not, add spacing."

The important thing for line height is that it makes imgui properly space multiline text so the lines don't look like they're touching. If you want to do the rest of the adjustment by adjusting all the arbitrary spacing values instead, that's fine. But it was easier for me to use GetLineHeight to match the old font size so I didn't have to mess with all the spacing numbers and verify that messing with them didn't break something else.

The only place it really matters is if you're trying to guess the result of CalcTextSizeA without actually calling it, which we do in a few places, but ideally we should actually call it and use the result instead of guessing.

TheLastRar · 2025-11-26T16:03:57Z

pcsx2/ImGui/ImGuiManager.h

-	void SetFontPath(std::string path);
+	struct FontInfo
+	{
+		std::span<const u8> data;
+		std::span<const u32> exclude_ranges;
+		const char* face_name;
+		bool is_emoji_font;
+	};
+
+	/// Sets a list of fonts to use.
+	void SetFonts(std::vector<FontInfo> info);



Given how we have to tread emoji fonts separately, would it make sense to pass those fonts as a second parameter instead of having to check is_emoji_font eveytime we iterate info?

Hopefully in the future we can treat emoji fonts less special, and it'll just be an is_emoji_font ? color : grayscale.

I'd like to keep them together.

Aside from the Glyph*AdvanceX setting, the main special treatment needed would be filtering the Variation Selector codepoints.
I'm suspecting that will probably be needed for as long as we use ImGui for text rendering.

Ahh true

I'd still like them together since it allows the font selection code to have minimal extra stuff to work around imgui's brokenness.

Side note, I'd like to get rid of the forced advance at some point, since it affects the spacing when used in normal text. If we want them to use a fixed amount of space when being used as icons, we should do that by separately rendering the icon and giving it a fixed amount of space, not by editing the font (which is shared by normal text rendering) to make it monospace.

Protects against all the other stuff we load eating up all the address space that we want

github-actions bot added Build | Project System Dependencies Pull requests that update a dependency file GUI/Qt OSD / ImGui labels Nov 23, 2025

Mrlinkwii added the Needs Rebase label Nov 24, 2025

TellowKrinkle force-pushed the AllTheFonts branch from 47467db to 0422418 Compare November 25, 2025 03:48

TellowKrinkle removed the Needs Rebase label Nov 25, 2025

TheLastRar requested changes Nov 25, 2025

View reviewed changes

pcsx2/ImGui/ImGuiManager.cpp Show resolved Hide resolved

pcsx2/ImGui/ImGuiManager.cpp Show resolved Hide resolved

TellowKrinkle force-pushed the AllTheFonts branch 2 times, most recently from 2f63b04 to 03f7350 Compare November 26, 2025 04:36

TellowKrinkle requested a review from TheLastRar November 26, 2025 04:38

TheLastRar reviewed Nov 26, 2025

View reviewed changes

TellowKrinkle added 2 commits November 26, 2025 23:47

Add functions to map a file into the process

37900ad

Core: Reserve memory map as early as possible

a553345

Protects against all the other stuff we load eating up all the address space that we want

TellowKrinkle force-pushed the AllTheFonts branch 2 times, most recently from e35ef57 to b1ba002 Compare November 27, 2025 06:43

github-actions bot added the RetroAchievements label Nov 27, 2025

TellowKrinkle added 3 commits November 27, 2025 00:56

FSUI: Use system fonts when available

67c57d8

imgui: Let caller handle memory management of font data

261771e

imgui: Don't shrink fonts based on their line height

a9ebd33

TellowKrinkle force-pushed the AllTheFonts branch from b1ba002 to c22d397 Compare November 27, 2025 06:56

Mrlinkwii approved these changes Nov 27, 2025

View reviewed changes

TellowKrinkle added 7 commits November 27, 2025 20:29

FSUI: Adjust sizes to match new font sizes

ace06d1

FSUI: Give horizontal titles a bit more space

72f22ae

CMake: Add option to skip installing Noto Color Emoji

decdc14

FSUI: Avoid needing two copies of every settings value query

ce397b1

Host: Add RunOnGSThread helper

d5fd0a8

FSUI: Support non-English game titles

6704bf4

FSUI: Use locale sensitive sort for game list

8a868bc

TellowKrinkle force-pushed the AllTheFonts branch from c22d397 to 8a868bc Compare November 28, 2025 02:29

Uh oh!

FSUI: Load all language fonts at all times #13589

Are you sure you want to change the base?

FSUI: Load all language fonts at all times #13589

Conversation

TellowKrinkle commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Changes

Rationale behind Changes

Suggested Testing Steps

Notes

Did you use AI to help find, test, or implement this issue or feature?

Uh oh!

Uh oh!

Uh oh!

TheLastRar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TellowKrinkle commented Nov 23, 2025 •

edited

Loading