Qt: Don't contain display surface when render to separate or fullscreen is used on Windows #13577
+247
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Does VRR work on AMD with a maximized container? iirc, Freesync (on AMD) only works will full screen applications, where Nvidia can do windows and full screen. Emulation is definitely made better by VRR :) Edit: I've been told VRR apparently works in borderless/window mode on AMD now, but getting super conflicting info online. There's also exclusive full screen to consider (a bunch of people will lose their crap if that no longer works lol). |
TheLastRar
force-pushed
the
UncontainedFullscreen
branch
2 times, most recently
from
4973001 to
43cac70
Compare
TheLastRar
force-pushed
the
UncontainedFullscreen
branch
from
43cac70 to
42e13d2
Compare
JordanTheToaster
approved these changes
Nov 22, 2025
Member
JordanTheToaster
left a comment
JordanTheToaster
left a comment
There was a problem hiding this comment.
Fixes fullscreen with DX11 and DX12 for me.
TheLastRar
changed the title
TheLastRar
force-pushed
the
UncontainedFullscreen
branch
from
42e13d2 to
0438dc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
On Windows, we don't contain
DisplaySurface, in render to separate or full-screening its container.Rationale behind Changes
DX11 & DX12 refuse to fullscreen with the current setup, they seem to require the surface be the top-level window when fullscreened.
QWindow doesn't get Client side decorations on Wayland, and I don't have a Mac to test on, so these changes are currently Windows only
None windows platforms continue to use a container for fullscreen.
Suggested Testing Steps
Test fullscreen.
Test exiting in and out of fullscreen.
Test render to separate window.
Test receiving popups during rendering while fullscreened.
Retest with Render to separate window.
Test if there are new frame pacing or latency issues while fullscreened.
The behaviour changes are Windows focused, but a test for other platforms is needed to make sure nothing broke.
Did you use AI to help find, test, or implement this issue or feature?
No