-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Qt/FSUI: Add language flag icons to settings and setup #13574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
TheLastRar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the replacement flags for the regions aren’t correct.
I've pointed out a two that I've noticed immediately, but I've not checked against my full library of games.
| } | ||
| else if (actual_language_code == QStringLiteral("sr-SP")) | ||
| { | ||
| // Serbia (SP) is not a valid ISO code, use RS (Serbia) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what happened here is that PCSX2 used i18n codes, saw no code existed for Latin American Spanish, and took es-419 from IETF BCP 47. sr-SP is a perfectly valid i18n code, but it seems like it'd be easier if we just brought everything in line with IETF BCP 47 so we don't need a special case for Serbia.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so looks like we can't change the country code because crowdin doesn't support IETF BCP 47 so we'll have to keep the special cases :(
|
( |
f69944f to
8a7998f
Compare
Signed-off-by: SternXD <[email protected]> f
…solete flag files Signed-off-by: SternXD <[email protected]>
…lenames Signed-off-by: SternXD <[email protected]>
Signed-off-by: SternXD <[email protected]>
kamfretoz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Description of Changes
Added country flag icons to the language selection dropdown in the Qt UI settings. Each language option now displays its corresponding flag icon to the left of the language name.
EDIT: Updated all the GameDB flags to these new flags too
(SVGs came from this repository https://github.com/lipis/flag-icons/tree/main/flags/4x3 which has an MIT license)
Rationale behind Changes
Flag icons make it easier to identify languages in the dropdown, especially for users familiar with flags. The "System Language [Default]" option now shows the flag corresponding to the user's actual system language.
Suggested Testing Steps
Did you use AI to help find, test, or implement this issue or feature?
No.