Skip to content

Conversation

@SternXD
Copy link
Contributor

@SternXD SternXD commented Nov 20, 2025

Description of Changes

image image

Added country flag icons to the language selection dropdown in the Qt UI settings. Each language option now displays its corresponding flag icon to the left of the language name.

EDIT: Updated all the GameDB flags to these new flags too

(SVGs came from this repository https://github.com/lipis/flag-icons/tree/main/flags/4x3 which has an MIT license)

Rationale behind Changes

Flag icons make it easier to identify languages in the dropdown, especially for users familiar with flags. The "System Language [Default]" option now shows the flag corresponding to the user's actual system language.

Suggested Testing Steps

  1. Open Settings -> Interface and check the Language dropdown each language should show its flag icon
  2. Check that "System Language [Default]" displays the correct flag for your system locale
  3. Test the setup wizard language selection page flags should appear there as well
  4. Make sure that special cases: "Español (Hispanoamérica)" shows Mexico flag, Serbian shows Serbia flag

Did you use AI to help find, test, or implement this issue or feature?

No.

@SternXD SternXD marked this pull request as draft November 20, 2025 23:12
@SternXD SternXD changed the title Qt: Add language flag icons to settings and setup Qt/FSUI: Add language flag icons to settings and setup Nov 21, 2025
@SternXD SternXD marked this pull request as ready for review November 21, 2025 00:05
Copy link
Contributor

@TheLastRar TheLastRar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the replacement flags for the regions aren’t correct.
I've pointed out a two that I've noticed immediately, but I've not checked against my full library of games.

}
else if (actual_language_code == QStringLiteral("sr-SP"))
{
// Serbia (SP) is not a valid ISO code, use RS (Serbia)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what happened here is that PCSX2 used i18n codes, saw no code existed for Latin American Spanish, and took es-419 from IETF BCP 47. sr-SP is a perfectly valid i18n code, but it seems like it'd be easier if we just brought everything in line with IETF BCP 47 so we don't need a special case for Serbia.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so looks like we can't change the country code because crowdin doesn't support IETF BCP 47 so we'll have to keep the special cases :(

@SternXD
Copy link
Contributor Author

SternXD commented Nov 21, 2025

(Will push later today (I didn't end up pushing later that day 😭) still need to figure out what flag to use for the Scandinavian countries i could just use the old flag which isn’t that big of a deal for me but in that regard just wanted to see what everyone wanted)

@SternXD SternXD marked this pull request as draft November 21, 2025 15:15
@SternXD SternXD force-pushed the qt-flags branch 2 times, most recently from f69944f to 8a7998f Compare November 23, 2025 22:47
@SternXD SternXD marked this pull request as ready for review November 23, 2025 23:11
Copy link
Contributor

@kamfretoz kamfretoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great.

Image

@JordanTheToaster JordanTheToaster added this to the Release 2.6 milestone Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants