GS/DX11: Don't unbind shader resource if depth stencil view is read only. #13539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly. We don't need to unbind conflicting srv with dsv if the dsv itself is read only, it is used for depth testing and both can be bind at the same time. Avoids re binding srv using a read only dsv.
lightningterror
force-pushed
the
gs_dx11_dsv_sample_binding
branch
from
f220214 to
5e9d969
Compare
Contributor
Author
|
Did another smoke test just in case with affected games and seem fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
GS/DX11: Don't unbind shader resource if depth stencil view is read only.
We don't need to unbind conflicting srv with dsv if the dsv itself is read only, it is used for depth testing and both can be bind at the same time.
Avoids re binding srv using a read only dsv.
Rationale behind Changes
Optimization.
Suggested Testing Steps
Test Sly 2, Time crisis 2, and other stuff you can find to make sure nothing broke.
At best games will be a few frames faster.
Did you use AI to help find, test, or implement this issue or feature?
No.