pcre2test: keep track of internal API with sljit platform names (WIP) #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SLJIT platform names used to be 64 bytes wide, but had since grown. Add a new header to keep track of those internal API numbers and use that to size the needed buffers accurately. While at it, do the same for the standalone JIT test which used by default a more realistic power of 2 buffer size.
NWilson
reviewed
Oct 28, 2025
Member
|
I will close this in favour of Carlo's second PR, which has conflicts with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
an early draft to help discussion on design, not even tested
See zherczeg/sljit#349 for context