Add gpg signing and verification support #185
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One problem this has is that all current signatures should be discarded when a change is made, otherwise, for example, my signature will be for an outdated sha256sum and verification will fail since your sig will be valid for current sha256sum and mine will become invalid... Since it is merely batch validating, if any one is incorrect it will fail... |
|
Perhaps instead of using the error code in a if then statement, the gpg --verify should just be run as-is and the user can read the valid/invalid list and decide which ones they care about... It's all a matter of preference imo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these bash scripts should make it easier to verify the hashes match for people who don't use git and just download the zip.
also switched to sha256