Skip to content

Conversation

@casper-jr
Copy link
Member

@casper-jr casper-jr commented Aug 13, 2025

🚀 이슈번호

✏️ 변경사항

  • AddMenuViewModel에 SelectedMenuData() 추가

📷 스크린샷

✍️ 사용법

🎸 기타

Summary by CodeRabbit

  • 신규 기능
    • 추가 흐름에서 선택한 메뉴 정보(메뉴명, 가격, 매장명, 주소)를 일관되게 표시·유지합니다.
  • 리팩터링
    • 더미 데이터 의존을 제거하고 상태 기반 관리로 전환해 입력 변경이 안정적으로 반영되고 화면 이동 시 값이 유지되며 전반적 안정성이 향상되었습니다.

@casper-jr casper-jr self-assigned this Aug 13, 2025
@casper-jr casper-jr added ⚡️ fix Extra attention is needed ♻️ refactor This doesn't seem right labels Aug 13, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

AddMenuViewModel에 SelectedMenuData 데이터 클래스를 추가하고, 이를 보관하는 _selectedMenuData: MutableStateFlow와 공개 selectedMenuData: StateFlow를 도입했습니다. 기존의 AddMenuDummyStoreInfo 데이터 클래스는 제거되었습니다.

Changes

Cohort / File(s) Summary
ViewModel 상태 관리 개편
app/src/main/java/com/kuit/ourmenu/ui/addmenu/viewmodel/AddMenuViewModel.kt
SelectedMenuData(menuName: String = "", price: String = "", storeName: String = "", address: String = "") 데이터 클래스 추가. 기존 AddMenuDummyStoreInfo(...) 데이터 클래스 제거. 내부 _selectedMenuData: MutableStateFlow<SelectedMenuData>와 공개 selectedMenuData: StateFlow<SelectedMenuData> 추가 및 노출.

Sequence Diagram(s)

sequenceDiagram
  participant View as View(UI)
  participant VM as AddMenuViewModel
  participant SF as selectedMenuData(StateFlow)

  View->>VM: 메뉴 선택/입력 이벤트 전달
  VM->>VM: _selectedMenuData 업데이트
  VM->>SF: updated SelectedMenuData 방출
  SF-->>View: 최신 SelectedMenuData 스트림 수신
  View->>View: UI 갱신
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

새로 들어온 작은 흐름, 값 네 개 조용히 모여
더미는 떠났고 선택은 말끔히 정리돼
이름·가격·가게·주소, 한 줄에 담긴 이야기
플로우 위로 흘러 UI에 미소를 남기네 🌊✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bee3531 and 32a1df2.

📒 Files selected for processing (1)
  • app/src/main/java/com/kuit/ourmenu/ui/addmenu/viewmodel/AddMenuViewModel.kt (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@casper-jr casper-jr merged commit a56eaa0 into OurMenu:develop Aug 13, 2025
1 of 2 checks passed
@casper-jr casper-jr deleted the fix/selectedmenu branch August 13, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚡️ fix Extra attention is needed ♻️ refactor This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant