Fix math function return types and calling conventions#12
Draft
Fix math function return types and calling conventions#12
Conversation
- Fixed return types for double-parameter functions (cosd, sind, sqrtd) to return double - Fixed return types for float-parameter functions to return float instead of double - Fixed calling convention inconsistencies (changed __stdcall to __cdecl) - Fixed syntax error in Hooks.Otamaa.cpp (missing opening parenthesis in sqrt call) - Fixed syntax errors in CircleDifferentiator.cpp (extra closing parentheses) Co-authored-by: deathreaperz <37824218+deathreaperz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix and correct math functions in repository
Fix math function return types and calling conventions
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected type inconsistencies in
PhobosMathwrapper functions where return types didn't match parameter types, and fixed several syntax errors preventing compilation.Changes
Return type corrections:
doubleparameters (cosd,sind,sqrtd) now returndoubleinstead offloatfloatparameters (all*fvariants) now returnfloatinstead ofdoubleCalling convention standardization:
asinf,atanf,atan2ffrom__stdcallto__cdeclfor consistencySyntax error fixes:
Hooks.Otamaa.cpp:7429- Fixed malformedMath::sqrtcall missing opening parenthesisCircleDifferentiator.cpp:6,9- Removed extraneous closing parenthesesExample
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.