fix(dashboard-api): use _positive_number for regex param matches in model_memory.py - #2620
Open
mohitchauhan221 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
ods/extensions/services/dashboard-api/model_memory.py,estimated_param_billions()extracts model parameter scales from model names and filenames usingre.findall(r"(\d+(?:\.\d+)?)\s*b", ...). Directly mapping matches withfloat(match)could raise aValueErroron malformed match groups.Fix
Use the existing
_positive_number()helper function to validate regex parameter scale matches safely before adding them to candidate scale numbers.Verification
Verified syntax with
python3 -m py_compile ods/extensions/services/dashboard-api/model_memory.py.git diff --checkpassed cleanly.