fix(hardware): add safe float parsing for vram_mb and ram_mb in classify-hardware.sh - #2615
Open
vaibhavsrv wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
ods/scripts/classify-hardware.sh, inline Python code parsedvram_mbandram_mbcommand line arguments usingint(float(sys.argv[...] or 0)). If non-numeric values were passed as arguments, Python raised an unhandledValueError.Fix
Add a local
safe_int_float()helper function inclassify-hardware.shto parse numeric memory parameters safely, defaulting to0on unparseable inputs.Verification
Verified syntax with
bash -n ods/scripts/classify-hardware.sh.git diff --checkpassed cleanly.