fix(opencode): wait for bootstrap compose stack on update - #2607
Open
patil2001 wants to merge 1 commit into
Open
fix(opencode): wait for bootstrap compose stack on update#2607patil2001 wants to merge 1 commit into
patil2001 wants to merge 1 commit into
Conversation
cmd_update recreated the compose stack without the readiness wait that cmd_start and cmd_restart use. Added macos_wait_for_bootstrap_compose_safe "update" || return 1 ahead of the recreate so an update cannot race the bootstrap compose stack coming up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmd_update recreated the compose stack without the readiness wait that cmd_start and cmd_restart already perform, so an update could race the bootstrap compose stack coming up. This adds macos_wait_for_bootstrap_compose_safe "update" || return 1 ahead of the force-recreate, mirroring the existing guard pattern.
AI Assistance
AI-assisted repository exploration and regression triage. The author reviewed the implementation, selected the validation scope, and is responsible for the final diff.
Release Lane
release/2.6.xmainStable hotfix reason:
Changed Surface
Validation