Skip to content

Conversation

@sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Jan 30, 2026

  • Migrating defender actions to a private transactions (MEV protected) has introduced a new issue where a transaction will be sent to the validators even if the transaction fails. This means that javascript code doesn't automatically revert when a transaction fails. This PR fixes that by verifying the transaction receipt and reverting if the transaction failed.
  • Fix issues with missing abi in EtherfiArm.json
  • Fix issues with sonic using an older deployment ABI for allocation

Related PR: OriginProtocol/origin-dollar#2774

All the actions that need to be updated:

  • OETH ARM - Claim Withdraws
  • OETH ARM - Request Withdrawal
  • EtherFi ARM - allocate to/from lending markets
  • EtherFi ARM - Request eETH withdraw
  • EtherFi ARM - Collect Fees
  • EtherFi ARM - price setter
  • EtherFi ARM - claim eETH withdraws
  • Lido ARM - price setter
  • Lido ARM - Request stETH withdraw
  • Lido ARM - allocate to/from lending markets
  • Lido ARM - Collect Fees
  • Ethena ARM - claim USDe withdraws
  • Ethena ARM - Collect Fees
  • Ethena ARM - allocate to/from lending markets
  • Sonic ARM - allocate to/from lending markets
  • Sonic ARM - claim base asset withdrawals
  • Sonic ARM - Set Price
  • Sonic ARM - Harvest rewards

shahthepro
shahthepro previously approved these changes Jan 30, 2026
clement-ux
clement-ux previously approved these changes Jan 30, 2026
clement-ux
clement-ux previously approved these changes Feb 3, 2026
Copy link
Contributor

@clement-ux clement-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo in allocateSonic.js "armContractVerion", otherwise looks good thanks 👍

naddison36
naddison36 previously approved these changes Feb 3, 2026
Copy link
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sparrowDom sparrowDom dismissed stale reviews from naddison36 and clement-ux via 31e456c February 3, 2026 23:07
@sparrowDom
Copy link
Member Author

nice catch @clement-ux thanks. Fixed here: 31e456c

Can I get another approval please so it can be merged?

@naddison36 naddison36 merged commit 8fce6a9 into main Feb 3, 2026
8 checks passed
@naddison36 naddison36 deleted the sparrowDom/defender-action branch February 3, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants