[OUDS] feat(component): update control items to last versions #3239
+1,206
−796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to In Progress / Draft
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
MaxLardenois
changed the title
boosted-bot
moved this from In Progress / Draft
to Need Dev Review
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
louismaximepiton
requested changes
Dec 3, 2025
Member
louismaximepiton
left a comment
louismaximepiton
left a comment
There was a problem hiding this comment.
It's looking alright, just a few words are missing in the radio-button page and also maybe some changes need to be done in that same page regarding the fiedset element
|
|
||
| <ControlItem /> | ||
|
|
||
| #### Control items list |
Member
There was a problem hiding this comment.
This architecture is missing in the radio-button page
| To add critical information to some of the options, add a `.radio-button-additional-label` as a sibling of a `.control-item-label`. Make sure the additional label is accessible by adding an `aria-describedby` attribute to the input. | ||
| To add critical information to some of the options, add a `.radio-button-extra-label` as a sibling of a `.control-item-label`. Make sure the extra label is accessible by adding an `aria-describedby` attribute to the input. | ||
|
|
||
| <Example code={`<div class="radio-button-item"> |
Member
There was a problem hiding this comment.
I think we should have <fieldset> in this page as well https://www.w3.org/WAI/tutorials/forms/grouping/
|
|
||
| #### Checkboxes | ||
|
|
||
| - <span class="tag tag-small rounded-none tag-positive">New</span> Checkbox component has been updated to 2.4.0. Read more in our [checkbox page]([[docsref:/forms/checkbox]]). |
Member
There was a problem hiding this comment.
I think this should be warning at least, since the DOM is updated
boosted-bot
moved this from Need Dev Review
to Dev Review In Progress
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
nilloq
reviewed
Dec 4, 2025
Member
nilloq
left a comment
nilloq
left a comment
There was a problem hiding this comment.
Nice components, I just added a small comment
| Here is the associated JavaScript to set a checkbox as indeterminate. | ||
|
|
||
| ```javascript | ||
| const checkbox = document.getElementById('checkbox') |
Member
There was a problem hiding this comment.
To be consistent with the above example, it should be
Suggested change
| const checkbox = document.getElementById('checkboxIndeterminate') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of change
Related issues
Closes #3212 #3213 #3214
Context & Motivation
Description
Checklists
Checklist (for Core Team only)
Progression (for Core Team only)
ouds/mainfollowing conventional commitLive previews