Skip to content

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jul 27, 2023

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

To rebase and merge after #1349.

Description

Add drawer content side navigation.

Things to take into account:

Motivation & Context

Missing one variant of the side navigation.
Splitted PR due to to many issue on this specific variant.

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes
  • (NA) I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 2fb3373
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6596d784363de60007f15bc8
😎 Deploy Preview https://deploy-preview-2180--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton marked this pull request as ready for review August 24, 2023 13:15
@louismaximepiton louismaximepiton marked this pull request as draft August 24, 2023 13:34
@louismaximepiton louismaximepiton marked this pull request as ready for review August 24, 2023 13:47
@louismaximepiton louismaximepiton marked this pull request as draft August 24, 2023 13:53
@louismaximepiton louismaximepiton marked this pull request as ready for review August 24, 2023 14:02
@louismaximepiton louismaximepiton marked this pull request as draft August 28, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress / Draft
Development

Successfully merging this pull request may close these issues.

2 participants