Unified data exchange protocol across modules #960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wheresmyhair
force-pushed
the
lmflow-dataproto-beta
branch
from
f47f272 to
0911ed4
Compare
wheresmyhair
force-pushed
the
lmflow-dataproto-beta
branch
from
0911ed4 to
b5616c1
Compare
Collaborator
Author
|
Comments on force-pushes: removed some personal info |
research4pan
approved these changes
Jan 3, 2026
Contributor
There was a problem hiding this comment.
LGTM. Support unified data protocol for inference purposes (support sglang first for now).
Main Features
- Support unified data protocol
DataProtofor sglang (vllm not implemented yet)src/lmflow/models/hf_decoder_model.py- lines 450: use "sampling_params" in inputs, allowing compatibility with vllm sampling params
src/lmflow/pipeline/sglang_inferencer.pysrc/lmflow/utils/protocol.py
Details
-
Change
--save_resultsargument to--save_inference_results,--save_resultsargument will be deprecated in future versions (still supported in this version)examples/rm_inference.pyscripts/archive/run_rm_inference.shscripts/archive/run_vllm_inference.shscripts/run_sglang_inference.sh: lines 11-12src/lmflow/args.pysrc/lmflow/pipeline/sglang_inferencer.py
-
Change default dataset example in
scripts/run_sglang_inference.sh(line 3) -
Change save format from json to pkl
src/lmflow/pipeline/sglang_inferencer.py
-
Add
tensordicttorequirements.txt -
Add useful util functions in
src/lmflow/utils/envs.py -
Improve
README.md -
Improve
gitignore
Suggestions
src/lmflow/pipeline/sglang_inferencer.py, line 104-106: better support json-format output as well, since pkl is normally not human-readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a unified data exchange protocol as a pilot implementation, enabling batch operations and improving developer experience.