Skip to content

fix: workflow for uploading sourcemap to sentry - #18563

Merged
koji merged 10 commits into
chore_release-pd-8.5.0from
fix_workflow-sourcemap-for-sentry
Jun 10, 2025
Merged

koji merged 10 commits into
chore_release-pd-8.5.0from
fix_workflow-sourcemap-for-sentry

Conversation

@koji

@koji koji commented Jun 7, 2025 •

Copy link
Copy Markdown
Contributor

Overview

remove upload-source map and move it to build-pd.
add deploy part to deploy-pd.

noticed that I put DNS in code instad of DSN 😭

https://docs.sentry.io/product/releases/setup/release-automation/github-actions/

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

fix workflow for uploading sourcemap to sentry
@codecov

codecov Bot commented Jun 7, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 24.89%. Comparing base (097cf95) to head (7cdfc32).
Report is 3 commits behind head on chore_release-pd-8.5.0.

Files with missing lines Patch % Lines
protocol-designer/src/resources/sentry.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           chore_release-pd-8.5.0   #18563      +/-   ##
==========================================================
+ Coverage                   23.78%   24.89%   +1.11%     
==========================================================
  Files                        3233     3259      +26     
  Lines                      279278   280069     +791     
  Branches                    27012    33611    +6599     
==========================================================
+ Hits                        66413    69732    +3319     
+ Misses                     212842   210316    -2526     
+ Partials                       23       21       -2     
Flag Coverage Δ
protocol-designer 19.26% <0.00%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol-designer/src/resources/sentry.ts 0.00% <0.00%> (ø)

... and 734 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji
koji marked this pull request as ready for review June 9, 2025 14:25
@koji
koji requested a review from a team as a code owner June 9, 2025 14:25
@koji
koji requested review from ddcc4, jerader and ncdiehl11 June 9, 2025 14:25

@ddcc4 ddcc4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This fixes the invalid value workflow reference: references to workflows must be rooted in '.github/workflows' error, right?

@ddcc4
ddcc4 changed the base branch from edge to chore_release-pd-8.5.0 June 9, 2025 17:45
@ddcc4

ddcc4 commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

@koji I changed your PR to target the chore_release-pd-8.5.0 branch instead, because the same problem exists there too.

@koji

koji commented Jun 9, 2025

Copy link
Copy Markdown
Contributor Author

Thanks! This fixes the invalid value workflow reference: references to workflows must be rooted in '.github/workflows' error, right?

yes

@koji
koji requested review from ddcc4 and y3rsh June 10, 2025 00:29
@koji
koji merged commit 954f9ae into chore_release-pd-8.5.0 Jun 10, 2025
@koji
koji deleted the fix_workflow-sourcemap-for-sentry branch June 10, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants