Repository navigation
fix: workflow for uploading sourcemap to sentry - #18563
Merged
Merged
Conversation
fix workflow for uploading sourcemap to sentry
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.5.0 #18563 +/- ##
==========================================================
+ Coverage 23.78% 24.89% +1.11%
==========================================================
Files 3233 3259 +26
Lines 279278 280069 +791
Branches 27012 33611 +6599
==========================================================
+ Hits 66413 69732 +3319
+ Misses 212842 210316 -2526
+ Partials 23 21 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ddcc4
approved these changes
Jun 9, 2025
ddcc4
left a comment
Contributor
There was a problem hiding this comment.
Thanks! This fixes the invalid value workflow reference: references to workflows must be rooted in '.github/workflows' error, right?
Contributor
|
@koji I changed your PR to target the |
Contributor
Author
yes |
move upload source map to in build-pd and update deploy-pd
ddcc4
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
remove upload-source map and move it to
build-pd.add deploy part to
deploy-pd.noticed that I put
DNSin code instad ofDSN😭https://docs.sentry.io/product/releases/setup/release-automation/github-actions/
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment