-
Notifications
You must be signed in to change notification settings - Fork 187
feat(protocol-designer): filter liquid class options and show warning #18559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer): filter liquid class options and show warning #18559
Conversation
This PR wires up liquid class filtering based on form field selection on page 1 of moveLiquid and mix forms. It also wires up the warning logic for showing why some (if any) liquid classes are disabled based on those selections and for prioritizing which warning should show if there are multiple reasons for disabling. Closes AUTH-1530
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.5.0 #18559 +/- ##
===========================================================
+ Coverage 25.00% 56.98% +31.97%
===========================================================
Files 3276 3274 -2
Lines 281719 282032 +313
Branches 33705 33751 +46
===========================================================
+ Hits 70453 160711 +90258
+ Misses 211240 121127 -90113
- Partials 26 194 +168
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…#18559) This PR wires up liquid class filtering based on form field selection on page 1 of moveLiquid and mix forms. It also wires up the warning logic for showing why some (if any) liquid classes are disabled based on those selections and for prioritizing which warning should show if there are multiple reasons for disabling. Closes AUTH-1530
Overview
This PR wires up liquid class filtering based on form field selection on page 1 of moveLiquid and mix forms. It also wires up the warning logic for showing why some (if any) liquid classes are disabled based on those selections and for prioritizing which warning should show if there are multiple reasons for disabling.
Closes AUTH-1530
Test Plan and Hands on Testing
Currently, all of our liquid classes support all Flex pipette, tip, and path combos (cool!), so we can only test the low volume (sub-1µl) property in practice.
Please also take a look at the logic in the new warnings.
Changelog
Review requests
see test plan
Risk assessment
low. the only scenario where liquid classes should be incompatible as of now are 1) OT-2 and 2) low volume