Skip to content

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Jun 6, 2025

Overview

This PR wires up liquid class filtering based on form field selection on page 1 of moveLiquid and mix forms. It also wires up the warning logic for showing why some (if any) liquid classes are disabled based on those selections and for prioritizing which warning should show if there are multiple reasons for disabling.

Closes AUTH-1530

Test Plan and Hands on Testing

Currently, all of our liquid classes support all Flex pipette, tip, and path combos (cool!), so we can only test the low volume (sub-1µl) property in practice.

Please also take a look at the logic in the new warnings.

Changelog

  • add new form warnings for liquid class incompatibility, including logic for determining warning priority
  • add hook for filtering for only compatible liquid classes in moveLiquid and mix forms
  • add tests

Review requests

see test plan

Risk assessment

low. the only scenario where liquid classes should be incompatible as of now are 1) OT-2 and 2) low volume

This PR wires up liquid class filtering based on form field selection on page 1 of moveLiquid and mix forms. It also wires up the warning logic for showing why some (if any) liquid classes are disabled based on those selections and for prioritizing which warning should show if there are multiple reasons for disabling.

Closes AUTH-1530
@ncdiehl11 ncdiehl11 self-assigned this Jun 6, 2025
@ncdiehl11 ncdiehl11 requested review from koji and jerader June 6, 2025 21:10
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 84.15094% with 42 lines in your changes missing coverage. Please review.

Project coverage is 56.98%. Comparing base (78651b9) to head (28d315b).
Report is 6 commits behind head on chore_release-pd-8.5.0.

Files with missing lines Patch % Lines
...lSteps/StepForm/StepTools/MoveLiquidTools/hooks.ts 2.77% 35 Missing ⚠️
...tocol-designer/src/steplist/formLevel/warnings.tsx 93.80% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           chore_release-pd-8.5.0   #18559       +/-   ##
===========================================================
+ Coverage                   25.00%   56.98%   +31.97%     
===========================================================
  Files                        3276     3274        -2     
  Lines                      281719   282032      +313     
  Branches                    33705    33751       +46     
===========================================================
+ Hits                        70453   160711    +90258     
+ Misses                     211240   121127    -90113     
- Partials                       26      194      +168     
Flag Coverage Δ
step-generation 4.39% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol-designer/src/constants.ts 92.50% <100.00%> (+26.72%) ⬆️
...rotocolSteps/StepForm/StepTools/MixTools/index.tsx 22.80% <100.00%> (+1.01%) ⬆️
...Steps/StepForm/StepTools/MoveLiquidTools/index.tsx 67.08% <100.00%> (+1.75%) ⬆️
...ocol-designer/src/pages/ProtocolOverview/index.tsx 64.68% <ø> (ø)
protocol-designer/src/steplist/formLevel/index.ts 48.22% <100.00%> (+0.36%) ⬆️
...igner/src/steplist/formLevel/test/warnings.test.ts 93.36% <100.00%> (+1.72%) ⬆️
...tocol-designer/src/steplist/formLevel/warnings.tsx 89.96% <93.80%> (+2.73%) ⬆️
...lSteps/StepForm/StepTools/MoveLiquidTools/hooks.ts 2.18% <2.77%> (+0.20%) ⬆️

... and 1684 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ncdiehl11 ncdiehl11 marked this pull request as ready for review June 6, 2025 21:33
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner June 6, 2025 21:33
@ncdiehl11 ncdiehl11 requested a review from koji June 9, 2025 17:24
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ncdiehl11 ncdiehl11 merged commit cd96e18 into chore_release-pd-8.5.0 Jun 9, 2025
22 checks passed
@ncdiehl11 ncdiehl11 deleted the pd_feat-filter-and-warn-liquidclasses branch June 9, 2025 18:53
SyntaxColoring pushed a commit that referenced this pull request Jun 10, 2025
…#18559)

This PR wires up liquid class filtering based on form field selection on
page 1 of moveLiquid and mix forms. It also wires up the warning logic
for showing why some (if any) liquid classes are disabled based on those
selections and for prioritizing which warning should show if there are
multiple reasons for disabling.

Closes AUTH-1530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants