Skip to content

refactor(app,components): Move labware positioning to the parent and support labware schema 3 #18557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 23 commits into
base: edge
Choose a base branch
from

Conversation

SyntaxColoring
Copy link
Contributor

Overview

Closes EXEC-1573 and maybe even EXEC-1278?

A very messy work in progress. Expect Git history to be rewritten.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@SyntaxColoring SyntaxColoring changed the title reLabware viewbox refactor(app,components): Move labware positioning to the parent and support labware schema 3 Jun 6, 2025
@SyntaxColoring SyntaxColoring requested a review from mjhuff June 6, 2025 18:34
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 14.90196% with 217 lines in your changes missing coverage. Please review.

Project coverage is 24.82%. Comparing base (831b80e) to head (e35965c).

Files with missing lines Patch % Lines
shared-data/js/helpers/labwareSchemaShims.ts 21.62% 58 Missing ⚠️
.../organisms/Desktop/CalibrationPanels/DeckSetup.tsx 0.00% 44 Missing ⚠️
...rc/hardware-sim/Labware/CalibrationBlockRender.tsx 2.70% 36 Missing ⚠️
shared-data/js/helpers/vectorMath.ts 11.11% 32 Missing ⚠️
...re-sim/Labware/labwareInternals/LabwareOutline.tsx 54.54% 10 Missing ⚠️
...top/CalibrationPanels/CalibrationLabwareRender.tsx 0.00% 7 Missing ⚠️
components/src/hardware-sim/Labware/Labware.tsx 0.00% 6 Missing ⚠️
...ponents/src/hardware-sim/Labware/LabwareRender.tsx 33.33% 6 Missing ⚠️
...ganisms/Desktop/Labware/LabwareDetails/Gallery.tsx 0.00% 5 Missing ⚠️
...rc/organisms/Desktop/Labware/LabwareCard/index.tsx 0.00% 3 Missing ⚠️
... and 5 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18557      +/-   ##
==========================================
- Coverage   24.83%   24.82%   -0.01%     
==========================================
  Files        3274     3275       +1     
  Lines      281044   281134      +90     
  Branches    33831    33827       -4     
==========================================
+ Hits        69786    69794       +8     
- Misses     211237   211319      +82     
  Partials       21       21              
Flag Coverage Δ
protocol-designer 19.29% <14.90%> (-0.01%) ⬇️
step-generation 4.37% <3.13%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../ErrorRecoveryFlows/shared/TwoColLwInfoAndDeck.tsx 0.00% <ø> (ø)
...terventionModal/MoveLabwareInterventionContent.tsx 0.00% <ø> (ø)
...re/EditOffset/CheckLabware/LPCLabwareJogRender.tsx 0.00% <ø> (ø)
...organisms/LegacyLabwarePositionCheck/JogToWell.tsx 0.00% <ø> (ø)
...ProtocolSetupLabware/LabwareLiquidsDetailModal.tsx 0.00% <ø> (ø)
...tup/ProtocolSetupLabware/SetupLabwareStackView.tsx 0.00% <ø> (ø)
.../src/organisms/WellSelection/Selection384Wells.tsx 0.00% <ø> (ø)
app/src/organisms/WellSelection/index.tsx 0.00% <ø> (ø)
components/src/hardware-sim/BaseDeck/BaseDeck.tsx 2.14% <ø> (ø)
...onents/src/hardware-sim/Deck/MoveLabwareOnDeck.tsx 3.71% <ø> (ø)
... and 32 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This is used in a bunch of places.
…sById.

This just changes the name and type to match what the object actually is.
e.g. this includes things like module addressable areas, which are not deck slots.
I confirmed that deleted todo comment got resolved a while ago.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant