Merge back 'chore_release-8.5.0' into 'chore_release-pd-8.5.0' #18554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r + ethanol, 1ch + 8ch (#18521)
# Overview After various discussions we decided to rename the liquid class API methods: `define_liquid_class` -> `get_liquid_class` `define_custom_liquid_class` -> `define_liquid_class` ## Review requests - I've updated the API version required for using `get_liquid_class` as v2.24. Are we okay with that? I think it doesn't make sense to keep it 2.23 because technically, 2.23 had a `define_liquid_class` and not `get..`. ## Risk assessment None for production code. Refactor only. Internal stakeholders who have been using liquid classes will need to update their protocols and API versions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.5.0 #18554 +/- ##
==========================================================
- Coverage 24.41% 23.90% -0.52%
==========================================================
Files 3149 3216 +67
Lines 263888 277036 +13148
Branches 24804 26988 +2184
==========================================================
+ Hits 64428 66223 +1795
- Misses 199437 210790 +11353
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
# Overview Added new definitions for Axygen 96 wellplate 500ul, SMC 384 read plate, Corning 96 wellplate 360ul lid, ibidi 96 square well plate 300 ul. ## Test Plan and Hands on Testing Validated dims through a test protocol "labware def checker" and LPC. Created labware definitions from technical drawings in the Labware Expansion Excel sheet. <!-- - Indicate the level of attention this PR needs. - Provide context to guide reviewers. - Discuss trade-offs, coupling, and side effects. - Look for the possibility, even if you think it's small, that your change may affect some other part of the system. - For instance, changing return tip behavior may also change the behavior of labware calibration. - How do your unit tests and on hands on testing mitigate this PR's risks and the risk of future regressions? - Especially in high risk PRs, explain how you know your testing is enough. --> Closes https://opentrons.atlassian.net/browse/AUTH-1942 --------- Co-authored-by: ABR <[email protected]> Co-authored-by: Rhyann Clarke <[email protected]>
…18560) # Overview Updates the gravimetric test script to use the new `get_liquid_class()` function and makes the gravimetric script always use the latest API version. ## Risk assessment None for production code. High for testing code if updating the api version is going to have a big impact on testing. If not, then low-none risk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this mergeback PR now to get approvals; will do the merge at end-of-day.
This pulls in Andy's liquid class parameter changes.
Currently, the merge is clean with no conflicts.