fix(api): Flex stacker store labware fix #18547
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…limit for labware smaller than tipracks - add `speed` arg to `_move_and_home_axis` so we can get rid if individual `move_axis` and `home_axis` in `store_labware` - remove `verify_shuttle_location` RETRACTED checks since `_prepare_for_action` already checks that the shuttle is in the EXTENDED position - use correct `start` and `color_name` arguments in the `identify` function
sfoster1
approved these changes
Jun 6, 2025
sfoster1
changed the title
ahiuchingau
approved these changes
Jun 7, 2025
| # to `prepare_for_action` instead | ||
| await self.verify_shuttle_location(PlatformState.RETRACTED) | ||
|
|
||
| # Check that labware was detected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We have the incorrect offset when storing labware on the stacker, which would cause labware already on the stacker to fall ~10-20mm.
Closes: EXEC-1469
Test Plan and Hands on Testing
Changelog
store_labwarewhere we were using the wrong height limit for labware smaller than tipracksspeedarg to_move_and_home_axisso we can get rid if individualmove_axisandhome_axisinstore_labwareverify_shuttle_locationRETRACTED checks since_prepare_for_actionalready checks that the shuttle is in the EXTENDED positionstartandcolor_namearguments in theidentifyfunctionReview requests
Risk assessment
low, unreleased