Skip to content

fix error doc links - #831

Open
ozgunozerk wants to merge 1 commit into
mainfrom
N-16
Open

fix error doc links#831
ozgunozerk wants to merge 1 commit into
mainfrom
N-16

Conversation

@ozgunozerk

@ozgunozerk ozgunozerk commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Fixes #830

PR Checklist

  • Tests
  • Documentation

Summary by CodeRabbit

  • Documentation
    • Updated transfer and burn error references to reflect the current error terminology.
  • Chores
    • Added rust-analyzer to the configured development toolchain.

@ozgunozerk
ozgunozerk requested a review from brozorec August 4, 2026 09:06
@ozgunozerk ozgunozerk self-assigned this Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0034ebfa-f36a-43ee-91dd-5d805ba7d120

📥 Commits

Reviewing files that changed from the base of the PR and between 9b5ed96 and 96a1cdf.

📒 Files selected for processing (2)
  • packages/tokens/src/rwa/mod.rs
  • rust-toolchain.toml

Walkthrough

This PR updates documentation comments in forced_transfer and burn to reference the correct error type FungibleTokenError::LessThanZero, and adds rust-analyzer to the Rust toolchain components list.

Changes

Documentation and Toolchain Update

Layer / File(s) Summary
Correct documented error type
packages/tokens/src/rwa/mod.rs
Doc comments for forced_transfer and burn now reference crate::fungible::FungibleTokenError::LessThanZero instead of the removed RWAError::LessThanZero.
Add rust-analyzer component
rust-toolchain.toml
The toolchain configuration now includes rust-analyzer alongside rustfmt, clippy, and rust-src.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: brozorec

Poem

A rabbit hops through docs so neat,
Fixing errors, quick and fleet.
LessThanZero finds its true name,
rust-analyzer joins the game.
Hop, hop, hooray — small tweaks, no blame! 🐇

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description links issue #830 and checks both items, but it does not describe the documentation-link changes. Add a short summary explaining the corrected error references and the purpose of the rust-analyzer toolchain change.
Out of Scope Changes check ⚠️ Warning The rust-toolchain.toml change adds rust-analyzer but is unrelated to fixing error documentation links for issue #830. Remove the rust-analyzer change or document a direct requirement for it in issue #830 and the pull request description.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: fixing error documentation links.
Linked Issues check ✅ Passed The documentation changes correct the RWA error references and address the inconsistency described in issue #830.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch N-16

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[N-16] - Error-Listing Inconsistencies Across RWA Modules

2 participants