-
Notifications
You must be signed in to change notification settings - Fork 43
release prep for v0.6.0 #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 54 54
Lines 5201 5201
=======================================
Hits 4997 4997
Misses 204 204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WalkthroughVersion release from 0.5.1 to 0.6.0 across the workspace, with updated dependency pins in multiple README files. A new governance module and corresponding stellar-governance documentation are introduced to outline timelock operations, scheduling, execution, and cancellation workflows. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
1-90: Reminder: External documentation sync required as noted in PR objectives.The PR objectives mention: "note to check versions in docs.openzeppelin.com and bump them if needed." Ensure that version references in the external documentation website have been verified and updated to 0.6.0 as part of this release preparation.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.lockaudits/Stellar Contracts Library v0.6.0 Audit.pdfis excluded by!**/*.pdf
📒 Files selected for processing (8)
Cargo.tomlREADME.mdpackages/access/README.mdpackages/accounts/README.mdpackages/contract-utils/README.mdpackages/governance/README.mdpackages/macros/README.mdpackages/tokens/README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: clippy-fmt-test (ubuntu-latest)
🔇 Additional comments (11)
packages/contract-utils/README.md (1)
145-145: Version pins updated consistently for v0.6.0 release.The dependency pins have been correctly updated from 0.5.1 to 0.6.0, aligning with the release objective.
Also applies to: 147-147
packages/access/README.md (1)
148-148: Version pins updated consistently for v0.6.0 release.The dependency pins have been correctly updated from 0.5.1 to 0.6.0, consistent with other package documentation updates.
Also applies to: 150-150
packages/accounts/README.md (1)
291-291: Version pin updated correctly for v0.6.0 release.The stellar-accounts dependency pin has been updated from 0.5.1 to 0.6.0 as expected.
packages/macros/README.md (1)
174-174: Version pin updated correctly for 0.6.0 release.The stellar-macros dependency has been pinned to 0.6.0, consistent with the workspace-wide version bump.
packages/tokens/README.md (1)
143-145: Dependency versions updated consistently for 0.6.0 release.Both stellar-tokens and stellar-macros have been pinned to 0.6.0, aligning with the workspace-wide version bump.
README.md (3)
20-21: New modules properly documented in project structure.The fee-abstraction and governance modules have been added to the project structure section with clear, concise descriptions of their purpose.
59-61: Workspace dependency versions updated consistently for 0.6.0 release.The three workspace packages have been pinned to 0.6.0, maintaining consistency with the version bump across the library.
20-21: Governance module documentation is properly documented.The
packages/governance/README.mdfile exists and contains appropriate documentation for the timelock module. Version pins are consistent with the 0.6.0 release across all packages (stellar-governance = "=0.6.0"), matching the patterns used in other package READMEs.Cargo.toml (1)
45-45: LGTM! Version bump is correctly applied.The workspace version has been properly updated to 0.6.0, consistent with the release preparation objectives.
packages/governance/README.md (2)
99-102: The example directoryexamples/timelock-controller/exists and is properly configured in the workspace with a complete Rust project structure (Cargo.toml and source files). The documentation reference is accurate.
27-87: No issues found. The code example compiles correctly and accurately reflects the actualstellar-governancepackage API. All function signatures, imports, and struct definitions match the implementation inpackages/governance/src/timelock/storage.rs.
Summary by CodeRabbit
Chores
Documentation
New Features
✏️ Tip: You can customize this high-level summary in your review settings.