-
Notifications
You must be signed in to change notification settings - Fork 182
Add ERC-20 option for embedding ERC-7786 based crosschain bridge #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
Caution Review the following alerts detected in dependencies. According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.
|
packages/core/solidity/src/erc20.ts
Outdated
| args: [ | ||
| { name: 'gateway', type: 'address' }, | ||
| { name: 'counterpart', type: 'bytes memory' }, | ||
| { name: 'allowOverride', type: 'bool' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be an argument in the public function. The contract has to hardcode a value IIUC. CC @Amxx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From @Amxx: allowOverride should be false by default so that links are immutable once set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also consider adding a comment explaining the choice of false and when to consider changing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an option for this with default as false.
|
I think "ERC-7786 Native" instead of "Embedded" is a clearer and more compelling name. Open to other suggestions involving ERC-7786. |
ERC20Crosschain.ERC20Bridgeable) now allows privileged roles to set the token bridge address after deployment (this is a breaking change).BridgeERC7802if desired, sinceBridgeERC7802requires a token address as a constructor argument. This implies the token must be deployed before the bridge.ERC20Crosschain) allows privileged roles to update links.To do: