Rename to OpenFact #20
Draft
+157
−235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
force-pushed
the
openfact
branch
3 times, most recently
from
d701230 to
25b7203
Compare
|
I've done some cursory testing of the renamed gem (ruby 3.2.8, aarch64) using the ruby container in podman. There's two integration tests failing on the openfact branch but they also fail on main. And there's some rubocop complaints in the github test which should be addressed separately. I’ve read through the changeset and it “looks good to me”. Let’s take it out of draft and get it approved and merged. |
kenyon
requested changes
Jun 24, 2025
| ## Facter release notes are now provided as part of the [official Puppet documentation](https://puppet.com/docs/puppet/7/release_notes_facter.html) and are no longer tracked in this file. | ||
| ## 4.11.0 | ||
|
|
||
| After 4.0.44, Facter release notes where provided as part of the [official Puppet documentation](https://puppet.com/docs/puppet/7/release_notes_facter.html) and where not tracked in this file. |
There was a problem hiding this comment.
Suggested change
| After 4.0.44, Facter release notes where provided as part of the [official Puppet documentation](https://puppet.com/docs/puppet/7/release_notes_facter.html) and where not tracked in this file. | |
| After 4.0.44, Facter release notes were provided as part of the [official Puppet documentation](https://puppet.com/docs/puppet/7/release_notes_facter.html) and were not tracked in this file. |
| @@ -20,6 +12,8 @@ used to inform conditional expressions in Puppet. | |||
| Documentation for the Facter project can be found on the [Puppet Docs | |||
| site](https://puppet.com/docs/puppet/latest/facter.html). | |||
|
|
|||
| At the time of writing, the OpenVoxProject does not have a documentation website. But your help is very welcome! Reach out to the [Documentation Special Interest Group](https://github.com/voxpupuli/community-triage/wiki/SIG.Documentation) if you want to help. | |||
There was a problem hiding this comment.
Suggested change
| At the time of writing, the OpenVoxProject does not have a documentation website. But your help is very welcome! Reach out to the [Documentation Special Interest Group](https://github.com/voxpupuli/community-triage/wiki/SIG.Documentation) if you want to help. | |
| At the time of writing, the OpenVoxProject does not have a documentation website. | |
| But your help is very welcome! | |
| Reach out to the [Documentation Special Interest Group](https://github.com/voxpupuli/community-triage/wiki/SIG.Documentation) if you want to help. |
| ## Licensing | ||
| See [LICENSE](https://github.com/puppetlabs/facter/blob/main/LICENSE) file. Puppet is licensed by Puppet, Inc. under the Apache license. Puppet, Inc. can be contacted at: [email protected] | ||
| See [LICENSE](LICENSE) file. OpenFact is licensed by the OpenVox Project as a community maintained implementation of Facter. The OpenVox Project can be contacted at: [email protected]. Puppet itself is licensed by Puppet, Inc. under the Apache license. Puppet, Inc. can be contacted at: [email protected]. |
There was a problem hiding this comment.
Suggested change
| See [LICENSE](LICENSE) file. OpenFact is licensed by the OpenVox Project as a community maintained implementation of Facter. The OpenVox Project can be contacted at: [email protected]. Puppet itself is licensed by Puppet, Inc. under the Apache license. Puppet, Inc. can be contacted at: [email protected]. | |
| See [LICENSE](LICENSE) file. | |
| OpenFact is licensed by the OpenVox Project as a community maintained implementation of Facter. | |
| The OpenVox Project can be contacted at: [email protected]. | |
| Puppet itself is licensed by Puppet, Inc. under the Apache license. | |
| Puppet, Inc. can be contacted at: [email protected]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the project name in the README, update the gemspec to use the name the community chose, and adjust CI workflow to use the pre_release / release workflows and rename the gem_release one to match the names in the openvox project.