Merged
Conversation
Adds grouping to menu items and submenus for the `Windows` menu, remove advanced visibility option, remove non-working height limiting for `TopBarMenuWrapper` since that caused bugs with submenus. Fix typo
Split menuItemConfig into a config and order part for easier handling
engbergandreas
requested review from
WeirdRubberDuck and
ylvaselling
and removed request for
ylvaselling
WeirdRubberDuck
approved these changes
Mar 12, 2026
Collaborator
WeirdRubberDuck
left a comment
WeirdRubberDuck
left a comment
There was a problem hiding this comment.
Looks good to me!
ylvaselling
requested changes
Mar 12, 2026
| // the offset is computed from the panels top left corner to the bottom right corner of the main window | ||
| defaultVisible: boolean; // Whether this panel is visible in the toolbar on startup | ||
| visible?: boolean; // TODO: investigate whether this is needed (as of 2024-10-23 its not being used) | ||
| advanced?: boolean; // Whether this panel is considered advanced and should only be shown to users with a high enough visibility level |
Member
Author
There was a problem hiding this comment.
We discussed during the meeting that we would remove visibility for panels so that all are available all the time.
Atleast that is was my understanding, @WeirdRubberDuck, didn't we also talk about this?
Collaborator
There was a problem hiding this comment.
That's how I remember it too 🤔
src/panels/Menu/hooks.ts
Outdated
| // ['HelpMenu'], so spreading it into deps avoids the referential instability of | ||
| // passing a new array each render | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [menuItems, ...(includeGroups ?? [])]); |
Collaborator
There was a problem hiding this comment.
This doesn't actually seem make any difference, placing const groups = (includeGroups ?? menuItemGroups) as readonly Included[]; outside the useMemo gives me as many renders as having it like this
ylvaselling
approved these changes
Mar 17, 2026
WeirdRubberDuck
added a commit
to OpenSpace/OpenSpace
that referenced
this pull request
Mar 18, 2026
* Windown panel reordering OpenSpace/OpenSpace-WebGui#202 * Fixes #3914 * QR code emnu modal to open GUI in browser: OpenSpace/OpenSpace-WebGui#198
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the GUI panels order and adds sub menus to Window, it also separates View -> Reordering to not affect the Window layout.
fixes OpenSpace/OpenSpace#3872
It also partially fixes json layout to automatically open panels that are defined as
isOpen = true. However, this only works if you at runtime load a config file. I was going to fix it for startup as well but the hole went deeper than expected so leaving that for another PRNew version:
menu-ordering-new.mp4
Old version:
menu-ordering-old.mp4