Skip to content

editoast: adapt api to forward can_backtrack from front to editoast - #18107

Open
ppitou wants to merge 2 commits into
devfrom
akz/api_forward_can_backtrack_to_editoast
Open

editoast: adapt api to forward can_backtrack from front to editoast#18107
ppitou wants to merge 2 commits into
devfrom
akz/api_forward_can_backtrack_to_editoast

Conversation

@ppitou

@ppitou ppitou commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

closes #18027

@github-actions github-actions Bot added area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service area:integration-tests Work on Integration test, by nature related to different services kind:api-change labels Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

⚠️ API changes

This Pull Request introduces some changes in the API:

  • please own it: notify or even prepare dedicated PR(s) to consumer projects

@ppitou
editoast: adapt api to forward can_backtrack from front to editoast
0a92764 
Signed-off-by: Angelina Kuntz <angelina.kuntz@epita.fr>
@ppitou
ppitou force-pushed the akz/api_forward_can_backtrack_to_editoast branch from 6300c7d to 0a92764 Compare August 13, 2026 09:33
@ppitou
ppitou marked this pull request as ready for review August 13, 2026 09:55
@ppitou
ppitou requested review from a team as code owners August 13, 2026 09:55
@ppitou
ppitou requested review from bougue-pe, hhirtz and leovalais and removed request for bougue-pe August 13, 2026 09:55
hhirtz
hhirtz approved these changes Aug 13, 2026
View reviewed changes

@hhirtz hhirtz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job 👍 just two nits feel free to resolve

Comment thread editoast/src/views/path/pathfinding.rs Outdated
Comment thread editoast/src/views/timetable/stdcm/request.rs Outdated
Erashin
Erashin reviewed Aug 13, 2026
View reviewed changes

@Erashin Erashin left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed: rn, PathfindingItem is exactly the same struct as core_client::PathItem. We could probably only use one common struct for both no?

EDIT: Nope i'm drunk. Same names, but locations are different types.

Comment thread editoast/src/views/timetable/stdcm/request.rs Outdated
Comment thread editoast/src/views/path/pathfinding.rs Outdated
Comment thread editoast/src/views/timetable/stdcm/request.rs Outdated
@ppitou
ppitou force-pushed the akz/api_forward_can_backtrack_to_editoast branch from 3301145 to dd7aeae Compare August 13, 2026 14:44
Erashin
Erashin approved these changes Aug 14, 2026
View reviewed changes

@Erashin Erashin left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx!

@RomainValls RomainValls mentioned this pull request Aug 14, 2026
Open
@ppitou
ppitou requested a review from emersion August 14, 2026 10:19
emersion
emersion approved these changes Aug 14, 2026
View reviewed changes

@emersion emersion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emersion emersion emersion approved these changes
@hhirtz hhirtz hhirtz approved these changes
@Erashin Erashin Erashin approved these changes
@leovalais leovalais Awaiting requested review from leovalais

At least 0 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules area:integration-tests Work on Integration test, by nature related to different services kind:api-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

api: modify api to forward can_backtrack information from front to editoast

4 participants

@ppitou @emersion @hhirtz @Erashin