front: use Duration for stop_for in times & stops table - #18091
Open
emersion wants to merge 3 commits into
Open
Conversation
emersion
force-pushed
the
emr/times-stops-duration
branch
from
August 12, 2026 12:20
5c271ec to
56914a2
Compare
emersion
marked this pull request as ready for review
August 12, 2026 12:21
Improves type safety. Signed-off-by: Simon Ser <contact@emersion.fr>
DurationCell's declaration is difficult to read because its props type is non-trivial. Extract that to a separate type. Signed-off-by: Simon Ser <contact@emersion.fr>
Improves type safety. Signed-off-by: Simon Ser <contact@emersion.fr>
emersion
force-pushed
the
emr/times-stops-duration
branch
from
August 12, 2026 12:31
56914a2 to
ecabf43
Compare
Math-R
reviewed
Aug 13, 2026
Comment on lines
+85
to
+90
| { | ||
| row, | ||
| field: 'stopDuration', | ||
| value: new Duration({ minutes: 15 }), | ||
| propagationMode: 'toDestination', | ||
| }, // +10min |
Contributor
There was a problem hiding this comment.
nit: I know that the conversion is good, but i found that the +10min commentary is a bit misleading as we pass minutes: 15 to Duration
Math-R
reviewed
Aug 13, 2026
| field: 'stopDuration', | ||
| value: new Duration({ minutes: 10 }), | ||
| propagationMode: 'fromDeparture', | ||
| }, // +5min |
Math-R
reviewed
Aug 13, 2026
| field: 'stopDuration', | ||
| value: new Duration({ minutes: 10 }), | ||
| propagationMode: 'fromDeparture', | ||
| }, // +10min |
Math-R
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.
Improves type safety.