editoast: add authorization to POST:/rolling_stock/{id}/livery - #17392
Merged
Sh099078 merged 1 commit intoJul 17, 2026
Merged
Conversation
Sh099078
changed the title
POST:/rolling_stock/{id}/livery
Sh099078
force-pushed
the
lf/perm-endpoint-rs-post-livery
branch
3 times, most recently
from
June 25, 2026 13:37
47fb55d to
255130b
Compare
github-actions
Bot
added
the
area:integration-tests
Sh099078
force-pushed
the
lf/perm-endpoint-rs-post-livery
branch
3 times, most recently
from
June 25, 2026 14:09
115dc58 to
81bd195
Compare
Sh099078
marked this pull request as ready for review
June 25, 2026 14:16
Sh099078
force-pushed
the
lf/perm-endpoint-rs-post-livery
branch
from
June 25, 2026 14:19
81bd195 to
0ec8a73
Compare
24 tasks
Sh099078
changed the title
POST:/rolling_stock/{id}/liveryPOST:/rolling_stock/{id}/livery
younesschrifi
approved these changes
Jun 26, 2026
younesschrifi
force-pushed
the
feature-branch/check-rolling-stock-privileges
branch
from
June 26, 2026 14:04
9cda363 to
af93581
Compare
Sh099078
force-pushed
the
feature-branch/check-rolling-stock-privileges
branch
from
June 29, 2026 14:35
af93581 to
49c63ff
Compare
younesschrifi
force-pushed
the
feature-branch/check-rolling-stock-privileges
branch
from
July 1, 2026 07:53
49c63ff to
25b1202
Compare
Sh099078
force-pushed
the
lf/perm-endpoint-rs-post-livery
branch
from
July 2, 2026 12:25
0ec8a73 to
c1b5c6e
Compare
Contributor
Author
|
rebased on the feature branch |
younesschrifi
force-pushed
the
feature-branch/check-rolling-stock-privileges
branch
from
July 3, 2026 12:33
25b1202 to
c6e470e
Compare
Sh099078
force-pushed
the
lf/perm-endpoint-rs-post-livery
branch
2 times, most recently
from
July 13, 2026 09:16
377d617 to
77d5954
Compare
Contributor
Author
|
rebase on dev & resolve conflict |
Sh099078
force-pushed
the
lf/perm-endpoint-rs-post-livery
branch
from
July 13, 2026 09:17
77d5954 to
c7d041c
Compare
younesschrifi
force-pushed
the
feature-branch/check-rolling-stock-privileges
branch
from
July 15, 2026 07:20
77c7390 to
3d24d43
Compare
Sh099078
force-pushed
the
lf/perm-endpoint-rs-post-livery
branch
from
July 15, 2026 08:45
c7d041c to
6ce627e
Compare
Contributor
Author
|
rebase |
leovalais
approved these changes
Jul 16, 2026
github-actions
Bot
removed
the
area:integration-tests
Signed-off-by: Loup Federico <16464925+Sh099078@users.noreply.github.com>
Sh099078
force-pushed
the
lf/perm-endpoint-rs-post-livery
branch
from
July 17, 2026 12:40
99cd32e to
b21c728
Compare
Sh099078
merged commit Jul 17, 2026
4f1a1fb
into
feature-branch/check-rolling-stock-privileges
31 checks passed
github-project-automation
Bot
moved this from Awaiting merge
to Awaiting Validation
in Board PI 20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #17364 / https://github.com/osrd-project/osrd-confidential/issues/1064.
Note
There were no existing tests for the endpoint. The PR does the minimum required to test its authorization (add a random png in the tests folder) but the endpoint could definitely use more tests later (I got a lot of different 5xx errors while trying to use the endpoint, it doesn't parse user input safely at all).
Note
The openapi description of the endpoint request body is wrong and should be changed (not in this PR though).
Authorization rules:
OperationalStudiesrole to post a livery.