Started implementation of IAuthenticationAsync #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added interface
IAuthenticationAsync(copied fromIAuthenticationand added Async postfix)Added methods on DomainServiceDescription :
TryGetAuthenticationServiceTypeIsAuthenticationServiceI'm not too sure about the naming of the methods and if DomainServiceDescription is where they should be located.
Tests are not written yet. I was looking at the existing tests in AuthenticationCodeProcessorTest. Should rewrite so it also verifies the behavior for the new interface? (right now I just changed some tests to use the new Interface, I will revert that.)
Should test be added for code generation? What existing tests are there for this?