Add Konica Minolta magicolor 2300W driver - #13
Conversation
|
Hi @tillkamppeter @SinghCod3r, I’ve opened PR #13 with the upstream m2300w driver source, PPD/Foomatic files, and related build files. The imported source and patch structure have been verified. Build/runtime testing is limited on Windows because the required Linux/CUPS environment is not available. Please review it and, if everything looks good, merge it. Thanks! |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 35 out of 46 changed files in this pull request and generated 6 comments.
Suppressed comments (2)
m2300w/src/m2300w-wrapper.in:212
eval "$KEY='$VAL'"assigns user-controlled values viaeval, which is command-injection prone (quotes/command substitutions in VAL can escape). Since only a fixed set of keys is allowed, avoidevaland assign via an explicitcase.
m2300w/src/m2300w.c:871- This
fgets(buffer, 256, ...)should use the actual buffer size (sizeof buffer) to avoid future mismatches ifbufferis resized (and to be consistent with the safer loop above).
| cat >> /tmp/m2300w.log <<EOF | ||
| #### new print job #### | ||
|
|
||
| Wrapper was called with command line: | ||
| $0 $@ |
| int readHeader; | ||
| char buffer[255]; | ||
|
|
||
|
|
||
| while ((fgets (buffer, 256, in_stream)) != NULL) { |
| *FoomaticRIPOptionSetting PrintoutMode=Draft.Gray: "-o PrintoutMode=Dr&& | ||
| aft.Gray " |
| *FoomaticRIPOptionSetting PrintoutMode=Draft.Gray: "-o PrintoutMode=Dr&& | ||
| aft.Gray " |
| if (colorMode == 0xf0) { | ||
| free (stFeld[0].encBuffer); | ||
| free (stFeld[0].blockBuffer); | ||
| free (stFeld[0].pageOut); | ||
|
|
||
| free (stFeld[1].encBuffer); | ||
| free (stFeld[1].blockBuffer); | ||
| free (stFeld[1].pageOut); | ||
|
|
||
| free (stFeld[2].encBuffer); | ||
| free (stFeld[2].blockBuffer); | ||
| free (stFeld[2].pageOut); | ||
| } | ||
| free (stFeld[3].encBuffer); | ||
| free (stFeld[3].blockBuffer); | ||
| free (stFeld[3].pageOut); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
This PR doesn't allign with the contributing.md file. After reviewing throw it, i request you to look out more before pushing any commits. And changes to the file is not what we want at the legacy-driver. |
|
Thanks for the feedback. I understand the issue and apologize for not checking the I’ll review the contribution guidelines and existing project structure properly before making further changes. I’ll also make sure future PRs stay within the expected scope and follow the repository’s contribution requirements. Thanks for pointing this out—I’ll take care to avoid this in future contributions. |
Summary
This PR adds the upstream m2300w driver for Konica Minolta magicolor 2300W/2400W printers.
Changes
Testing
Notes
The driver source is based on the upstream m2300w 0.51 release.